| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
The doxygen files contained some deprecated values and typos.
This patch cleans them for all interfaces exposed by ding libs.
|
|
|
|
| |
This patch fixes the doxygen warnings in the new interface.
|
|
|
|
| |
Pointer was not initialized before being read.
|
|
|
|
|
| |
This patch stops building interface docs for the old interface
and starts generating description for the new interface.
|
| |
|
|
|
|
|
|
|
|
|
| |
The three files in the patch implement the functions
of the new interface. It is mostly inspired by the old
interface except that the string value is replaced with
the value object that hides all the metadata about
the value itself. The main function to get value
now allows more than one value per key.
|
|
|
|
|
|
|
| |
The search state allows one to search a configuration object
for the same key in the cases when a key permits more
than one value scattered across the config file.
The state needs to be stored, initialized and properly cleaned.
|
|
|
|
|
|
|
|
| |
Some time ago I started the new INI interface
that exists in parallel to the existing interface
but uses value object to store value rather than just
strings. The header has all the details about the new
interface.
|
|
|
|
|
|
|
|
|
| |
The patch adds function to get the length of
the concatenated value. It also adds a convenince
print function that is convenint in debugging
the values inside configuration object.
Patch also add checkes for input values
that can be passed by pointer.
|
|
|
|
|
|
|
|
|
| |
The unit test was broken. The wrong function was used.
To make sure everything is correct I also added a convenience
function to print the internals if the file context object.
The unit test is fixed to use relative paths consitently.
Also added nice statements at the beggining and the end of
the unit test functions where they were missing.
|
| |
|
|
|
|
|
|
|
|
| |
When running 'make distcheck', all files in the $srcdir are set to
read-only, to ensure that the build does not modify the source.
However, this broke our ability to test file permissions. We will
now copy the file to the builddir and do the tests there, where
we have control.
|
|
|
|
|
| |
This patch makes two internal functions
resusable from different source modules.
|
|
|
|
|
|
|
|
|
| |
It occured to me that one of the issues that Coverity
did not like (and I could not understand what it is
complaining about) is related to intializing the variables
in the loop.
This patch adds initialization in the loops.
Also there was an initialization missing in the ini_configobj.c
|
|
|
|
|
|
|
|
|
|
| |
All config file processing functions start with "ini_config".
The only function that does not comply is
ini_print_errors. We can't rename it since
it is a part of the current active interface.
I marked that function needs to be removed when we
remove old interface and created a copy with
the correct name. I also updated unit test accordingly.
|
|
|
|
|
| |
Patch adds two functions. One tests permissions,
another validates if the file has changed or not.
|
|
|
|
| |
Added function to detect changes to the configuration file.
|
|
|
|
|
|
| |
Added check access constants and the check access function.
The function is effectively copied from ini_metadata.c
The flags are copied from ini_config.h
|
|
|
|
|
|
|
|
|
|
|
|
| |
After some more thinking I decided not to use
metadata collection. It seems to be an overhead.
Patch does following:
* Replaces metadata collection in file context structure
with standard file stats
* Removes all operations against old metadata collection
* Defines new flags for data to collect
* Creates a function that consolidates common operations
between open and reopen functions.
|
|
|
|
|
| |
This patch would allow to reopen file
and create a new context based on the old one.
|
|
|
|
| |
Allow closing file without destroying the context.
|
|
|
|
| |
Spotted style violation.
|
|
|
|
|
|
| |
New test reads smerge.conf in all possible
modes and compares the combined result with
the sexpect.conf function.
|
|
|
|
|
|
| |
Patch adds smerge.conf file to the list
of files to test and adds test for the DETECT
mode for inidividual values.
|
|
|
|
|
|
|
| |
smerge.conf - test file
sexpect.conf - file contains output of the smerge.conf
processed in different merge modes
for sections and values
|
|
|
|
|
| |
If in merge DETECT mode and there were no parsing errors
return error if there were merge collisions.
|
|
|
|
|
|
| |
This patch adds functionality to respect
merge section flags and to process section
collisions differently dpending on these flags.
|
|
|
|
|
| |
Use section line number for error reporting
about the section collisions.
|
|
|
|
|
|
|
|
|
| |
This patch refactores the value processing
function so that it can be used both in
normal mode when velues need to be constrcuted and
saved into the current section (po->sec) and in the
merge mode when values are already constructed
and need to be saved into a po->merge_sec.
|
|
|
|
|
|
|
|
| |
Patch implements three functions:
* Function to detect a collision between two section names.
* Function to empty section from all its keys
* Function to add values one by one from one section to
another.
|
|
|
|
|
|
| |
* Changed parse_error to use save_error function
created in previous commit.
* Fixed comment to be more clear.
|
|
|
|
| |
Create a function to add error into error list.
|
|
|
|
|
| |
Adding new varibles to the internal parsing structure
and initializing them.
|
|
|
|
|
|
|
| |
Adding "DETECT" merge modes.
These modes would be useable for dry run cases to detect
if there are any potential merge conflicts.
Patch just defines new constans and adds input checks.
|
|
|
|
|
|
|
|
| |
Patch consists of two parts:
* Adding new constants for error messages to ini_configobj.h file
* Making ini_print.c use this header file instead of the old one.
Converting this to enums is tracked as a separate ticket.
|
|
|
|
|
| |
The fact that the other_test could return EOK on error
was the actual problem.
|
|
|
|
|
| |
* Do not set ext_data parameter to NULL
* include a private header to avoid implicit declarations
|
|
|
|
|
| |
Previous fix was not complete.
Secondary scan revealed other issues.
|
|
|
|
|
|
| |
Previous fix was not complete. New scan revealed
potential memory leak in case of coding error.
Low severity but still a bug...
|
|
|
|
| |
One liner to eliminate compilation warning.
|
|
|
|
|
|
|
|
| |
I decided not to redo the whole test.
It would have been too much work.
Just cleaned the code a bit and freed
allocated memory.
It is Coverity issue 10075.
|
|
|
|
|
|
| |
The newly created value object was not freed
in case of an error.
Coverity issue 10076.
|
|
|
|
|
|
|
|
|
| |
Allocating simple buffer is not enough.
It needs to be initialized with something.
The patch does exactly this for the case when
the empty comment string is represented by a NULL
value in the function input variable.
Coverity issue 10073.
|
|
|
|
| |
One liner to fix Coverity isssue 10044.
|
|
|
|
|
| |
Noticed under valgrind then checked
and saw that this is a coverity issue 10077.
|
|
|
|
|
|
| |
The 'len' varible was not initialized properly.
The ref_array_get function does not return error so
the error check is removed.
|
|
|
|
|
|
|
|
| |
I investigated the coverity issue 10043.
Reading code did not reveal the issue.
I added the test just to be sure and ran
valgrind again. It does not seem to leak
despite the Coverity concerns.
|
|
|
|
|
|
|
|
| |
The paths to test files did not work in
parallel build or 'make diskcheck' cases.
Now they are corrected. All temp files are
created in the build directory and read
from there.
|
|
|
|
|
|
| |
This patch addresses the crashes with the file object
when the file is not there and the file context
needs to be destroyed during the open operation.
|
|
|
|
|
|
|
| |
* Rearranged code in parser module and
created a skeleton of the function that will
be responcible for merging sections.
* Added missing static declarations to some functions.
|