summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2009-12-11 16:43:57 +0100
committerDenys Vlasenko <vda.linux@googlemail.com>2009-12-11 16:43:57 +0100
commit890f62322fc8fee262e39a10428b1a2489edf267 (patch)
tree1d4af471459ad12ffb3c3041b628df056f9cb15c /lib
parent4cd94cba0537d47078dac0c075b8ba55a7c53599 (diff)
downloadabrt-890f62322fc8fee262e39a10428b1a2489edf267.tar.gz
abrt-890f62322fc8fee262e39a10428b1a2489edf267.tar.xz
abrt-890f62322fc8fee262e39a10428b1a2489edf267.zip
abrt-cli: report success/failure of reporting. closes bug 71
See https://fedorahosted.org/abrt/ticket/71 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/Plugins/Logger.cpp4
-rw-r--r--lib/Utils/logging.cpp1
2 files changed, 3 insertions, 2 deletions
diff --git a/lib/Plugins/Logger.cpp b/lib/Plugins/Logger.cpp
index 35f042c..a0dea42 100644
--- a/lib/Plugins/Logger.cpp
+++ b/lib/Plugins/Logger.cpp
@@ -63,7 +63,6 @@ std::string CLogger::Report(const map_crash_report_t& pCrashReport,
const map_plugin_settings_t& pSettings,
const char *pArgs)
{
- update_client(_("Creating a report..."));
std::string description = make_description_logger(pCrashReport);
description += "\n\n\n";
@@ -80,12 +79,13 @@ std::string CLogger::Report(const map_crash_report_t& pCrashReport,
if (fOut)
{
+ update_client(_("Writing report to '%s'"), m_sLogPath.c_str());
fputs(description.c_str(), fOut);
fclose(fOut);
return "file://" + m_sLogPath;
}
- throw CABRTException(EXCEP_PLUGIN, "Can't open file '%s'", m_sLogPath.c_str());
+ throw CABRTException(EXCEP_PLUGIN, "Can't open '%s'", m_sLogPath.c_str());
}
PLUGIN_INFO(REPORTER,
diff --git a/lib/Utils/logging.cpp b/lib/Utils/logging.cpp
index db952d1..53b83d7 100644
--- a/lib/Utils/logging.cpp
+++ b/lib/Utils/logging.cpp
@@ -60,6 +60,7 @@ static void verror_msg_helper(const char *s, va_list p, const char* strerr, int
fflush(stdout);
full_write(STDERR_FILENO, msg, used + msgeol_len);
}
+ msg[used] = '\0'; /* remove msg_eol (usually "\n") */
if (flags & LOGMODE_SYSLOG) {
syslog(LOG_ERR, "%s", msg + prefix_len);
}