KerneloopsScanner: do not use global variables needlessly

   text	   data	    bss	    dec	    hex	filename
  27341	   1688	     48	  29077	   7195	old/libKerneloopsScanner.so
  26466	   1672	     24	  28162	   6e02 new/libKerneloopsScanner.so

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

1 files changed, 6 insertions, 7 deletions

diff --git a/lib/Plugins/KerneloopsScanner.cpp b/lib/Plugins/KerneloopsScanner.cpp
index 60fa92e..317aeab 100644
--- a/lib/Plugins/KerneloopsScanner.cpp
+++ b/lib/Plugins/KerneloopsScanner.cpp
@@ -83,12 +83,10 @@ void CKerneloopsScanner::SaveOopsToDebugDump()
 	m_pSysLog.ClearOopsList();
 
 	while (!oopsList.empty()) {
-		char path[PATH_MAX];
-		snprintf(path, sizeof(path), "%s/kerneloops-%lu-%lu",
-			DEBUG_DUMPS_DIR, (long)t, (long)oopsList.size());
-
+		char path[sizeof(DEBUG_DUMPS_DIR"/kerneloops-%lu-%lu") + 2 * sizeof(long)*3];
+		sprintf(path, DEBUG_DUMPS_DIR"/kerneloops-%lu-%lu",
+				(long)t, (long)oopsList.size());
 		COops oops = oopsList.back();
-
 		try
 		{
 			CDebugDump debugDump;
@@ -171,9 +169,10 @@ int CKerneloopsScanner::ScanSysLogFile(const char *filename)
 
 void CKerneloopsScanner::SetSettings(const map_plugin_settings_t& pSettings)
 {
-	if (pSettings.find("SysLogFile") != pSettings.end())
+	map_plugin_settings_t::const_iterator it = pSettings.find("SysLogFile");
+	if (it != pSettings.end())
 	{
-		m_sSysLogFile = pSettings.find("SysLogFile")->second;
+		m_sSysLogFile = it->second;
 	}
 }