summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Set a transient parent for GtkDialogsPavel Grunt2014-12-194-13/+41
| | | | | Silence the Gtk 3.14 message: "GtkDialog mapped without a transient parent. This is discouraged."
* msi/nsis: fix keyboard-shortcuts icon locationMarc-André Lureau2014-12-152-2/+2
| | | | | The /usr/share/icons/gnome icon theme location has been replaced with Adwaita in f21, fix the path.
* msi: add gtk3 supportFabiano Fidêncio2014-12-154-5/+827
| | | | | | | | | Add support to build the virt-viewer's msi using GTK3. For the GTK3 build, in order to provide all used icons for Windows systems we have to include manually all the icons we want to or add adwaita-icon-theme as dependency. I've decided to go with the first approach, what can be improved when we have "foreach" support in msitools (https://bugzilla.gnome.org/show_bug.cgi?id=741296).
* msi: add libgovirt as dependencyFabiano Fidêncio2014-12-151-0/+2
| | | | libgovirt is used to provide support to foreign menu using ovirt.
* nsis: add missing 24x24 iconsFabiano Fidêncio2014-12-151-0/+4
|
* nsis: add gtk3 supportFabiano Fidêncio2014-12-152-24/+281
| | | | Add support to build the virt-viewer's nsis using GTK3.
* nsis: remove $INSTDIR\etcFabiano Fidêncio2014-12-151-0/+1
|
* nsis: remove $INSTDIR\etc\libvirtFabiano Fidêncio2014-12-151-0/+1
|
* nsis: remove dup entriesFabiano Fidêncio2014-12-151-4/+0
|
* nsis: add libgovirt (and its dependencies)Fabiano Fidêncio2014-12-151-0/+21
| | | | libgovirt is used to provide support to foreign menu using ovirt.
* nsis: add libwinpthread-1.dllFabiano Fidêncio2014-12-151-0/+2
| | | | libwinpthread-1.dll is a dependency of libvirt
* nsis: add libopus-0.dllFabiano Fidêncio2014-12-151-0/+2
| | | | libopus-0.dll is a dependency of spice-glib
* nsis: add libnettle-4-7.dll (and its dependencies)Fabiano Fidêncio2014-12-151-0/+11
| | | | | | | | | | | | | | | | | | libgcc_s_sjlj-1 is needed by libgmp (on x86) libgcc_s_seh-1 is needed by libgmp (on x86_64s) libgmp-10.dll is needed by libnettle libhogweed-2-5.dll is provided by libnettle libnettle-4-7.dll is needed by gnutls gnutls is needed by gvnc and libvirt An interesting point here that worth to mention is the usage of /nonfatal when including libgcc_s_{sjlj,seh}-1.dll. As we only have the _seh in x64 the build breaks trying to add "not found" files. A check for arch was one option to solve the problem, but _sjlj may exist in x64 as well, when using an old gcc. An explicit check if the file exists (in compile time) was another idea, but for some reason the "-" part of the filename was interpreted as a math operand, breaking the build. With all that in mind, adding /nonfatal was the most convenient solution.
* nsis: update libgnutls versionFabiano Fidêncio2014-12-151-2/+2
| | | | Use version -28 instead of -26, matching what currently is in f21.
* nsis: update libtasn1 versionFabiano Fidêncio2014-12-151-2/+2
| | | | Use version -6 instead of -3, matching what currently is in f21.
* nsis: update libpng versionFabiano Fidêncio2014-12-151-2/+2
| | | | | Use libpng15-15 instead of libpng16-16, matching what currently is in f21.
* nsis: update libgcrypt versionFabiano Fidêncio2014-12-151-2/+2
| | | | Use version -20 instead of -11, matching what currently is in f21.
* display-vnc: fix zoom-level set by command linePavel Grunt2014-12-101-0/+1
| | | | | | | | Setting the zoom-level using the command line option '--zoom' is not working for vnc guests. This problem can be solved by emitting the "display-desktop-resize" signal when vnc is initialized. https://bugzilla.redhat.com/show_bug.cgi?id=1170071
* Do not show twice error dialog when no VM are foundMarc-André Lureau2014-12-011-1/+0
| | | | | When running virt-viewer without argument, and no VM are found, you get two error dialogs. Only one is enough.
* spice: calling VirtViewerSession:close() can destroy selfMarc-André Lureau2014-12-011-0/+7
| | | | | | | | | | | | | | | | | SpiceSession in spice-gtk v0.27 will remove channels from session during disconnect (and not when they are actually disposed). When no channels are left, session-disconnected is emitted, and the VirtViewerSession will be unref from the application. Use a weak reference to self to avoid crashing after calling spice_session_disconnect() As a workaround for existing clients, spice-gtk v0.27 will defer the disconnection to idle time. But the fix still makes sense and would prevent potentially future issues if spice-gtk changes back to sync disconnection. (the alternative of calling ref/unref would needlessly recreate a SpiceSession with a call to create_spice_session(), which is something we can avoid when leaving the application)
* virt-viewer: allow connection to unix socket only serverMarc-André Lureau2014-11-251-7/+8
| | | | | Even when the server doesn't provide a display connection address, virt-viewer is able to connect to guest with libvirt attach.
* Report error on attach-only displayMarc-André Lureau2014-11-251-2/+5
| | | | | Provide error details if the display can only be access through libvirt --attach method.
* Report error in dialogMarc-André Lureau2014-11-251-3/+11
| | | | Use a UI dialog to inform of connection error.
* Simplify virt_viewer_initial_connect()Marc-André Lureau2014-11-251-6/+6
| | | | | | | - do not overwrite err if ->initial_connect() sets it - remove need for waitvm if the display server isn't yet started (note: this function might be untested, I am not sure relying on libvirt events is enough)
* Simplify virt_viewer_initial_connect()Marc-André Lureau2014-11-251-10/+3
| | | | | | - remove need for waitvm if the display server isn't yet started (note: this function might be untested, I am not sure relying on libvirt events is enough)
* Simplify virt_viewer_initial_connect()Marc-André Lureau2014-11-251-21/+21
| | | | | | | | Some refactoring to make the code easier to read, mostly code movement/reindenting and introduction of a "wait" label which has the same purpose as "done". This also adds a "goto wait" within an if block, but this does not change the initial code flow, just makes it more explicit.
* Remove VIRT_VIEWER_VM_CHOOSE_DIALOG_CANCELLEDMarc-André Lureau2014-11-254-18/+5
| | | | | | This error type isn't really an error, it is used to skip error report code. The functions can simply return FALSE on failure, without GError set, to indicate that program should quit normally.
* Limit HAVE_SOCKETPAIR to directly concerned codeMarc-André Lureau2014-11-251-3/+6
|
* Move libvirt reconnect polling to VirtViewerMarc-André Lureau2014-11-253-40/+37
| | | | | This is libvirt specific, no need to share it in the VirtViewerApp base class.
* spice: use virt_viewer_signal_connect_objectMarc-André Lureau2014-11-251-25/+30
| | | | | | This isn't required, but makes it easier to track reference issues, as you have guarantee that callbacks won't be executed if the objects are disposed.
* Add virt-viewer-usb.pngFabiano Fidêncio2014-11-242-1/+1
| | | | Windows XP (at least) doesn't recognize .svg files
* Replace priv->withEvents usage for priv->domain_eventFabiano Fidêncio2014-11-201-9/+4
| | | | Once we have priv->domain_event, we don't need priv->withEvents anymore
* Prefer to use virConnectDomainEventRegisterAny()Fabiano Fidêncio2014-11-201-7/+13
| | | | | The usage of virConnectDomainEventRegister() is no longer recommended according to the libvirt's documentation.
* Set freed priv->dom to NULL in _dispose()Fabiano Fidêncio2014-11-201-1/+3
| | | | Avoid a possible use/free after the object has been freed.
* Make sure conn exists before use itFabiano Fidêncio2014-11-201-7/+9
| | | | | | Although all the used functions have a explicit check for a valid virConnPtr, let's be safe and only use priv->conn when its value is non-NULL.
* VirtViewerApp: Never remove main windowChristophe Fergeau2014-11-181-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | It's currently possible to destroy any virt-viewer window, including the main window. However, some part of the code expects that the main window is always present, for example to present status messages. In particular, stopping the guest (or running virsh destroy) will close all windows: virt_viewer_session_clear_displays will get called, which will call into virt_viewer_app_remove_display_removed, and finally into virt_viewer_app_remove_nth_window, which will destroy the window being removed if it holds the last reference to it. So going through virt_viewer_session_clear_displays, all VirtViewerWindow instances and their corresponding GtkWindow have been destroyed. This is already an issue as VirtViewerApp::main_window will be pointing to freed memory. When using virt-viewer --reconnect, this will cause a crash when restarting the guest in virt_viewer_app_create_session as it tries to get a valid GtkWindow through: GtkWindow *window = virt_viewer_window_get_window(priv->main_window); This commit avoids this issue by special casing the main window in virt_viewer_app_remove_nth_window to ensure it never gets removed. This is similar to what is done in virt_viewer_app_hide_all_windows.
* Fix check of virt_viewer_app_initial_connect return valueChristophe Fergeau2014-11-141-1/+1
| | | | | | | Commit 13f493200 changed virt_viewer_app_initial_connect to return a gboolean rather than an int, but one call site was not updated to the new convention, and was still checking for a negative value rather than for FALSE in order to detect failures.
* Check for spice-gtk 0.26 instead of a git snapshot of 0.25Daniel P. Berrange2014-11-041-1/+1
| | | | | | As spice-gtk macro for checking the version numbers was broken, let's check for 0.26 and avoid to have virt-viewer broken on a few distros for a good long time.
* Don't use virGetLastErrorMessage()Christophe Fergeau2014-10-311-1/+2
| | | | This was introduced in libvirt 1.0.6 but we only require libvirt 0.10.0
* Don't call local variable 'select'Christophe Fergeau2014-10-311-4/+4
| | | | | | | This causes warnings with older compilers virt-viewer-vm-connection.c:52: warning: declaration of 'select' shadows a global declaration /usr/include/sys/select.h:109: warning: shadowed declaration is here
* Avoid log message warning messages due to incorrect int formatDaniel P. Berrange2014-10-271-1/+3
| | | | | | | The G_N_ELEMENTS() type is size_t but this was being passed to a format string with '%lu' which is of a different size on many platforms. Just delete this part of the warning message since it was not hugely useful.
* Add new ui files to the RPMsDaniel P. Berrange2014-10-272-0/+6
|
* Avoid use of non-literal string with g_debugDaniel P. Berrange2014-10-272-3/+3
|
* Fix typo s/to to/to/Daniel P. Berrange2014-10-271-1/+1
|
* Remove useless 'if (...)' before free()Daniel P. Berrange2014-10-272-6/+2
| | | | | The 'free()' function accepts NULL, so you should not check for NULL before calling it.
* Don't try to re-configure displays when there are noneJonathon Jongsma2014-10-271-0/+3
| | | | | | virt_viewer_session_on_monitor_geometry_changed() gets called immediately upon agent connection, but sometimes this is before any displays have been received. Simply return early when this is the case.
* Shift top-left display to originJonathon Jongsma2014-10-274-5/+60
| | | | | | | | | | | | | | When using a custom fullscreen display configuration, it's possible to specify that e.g. a single screen should be fullscreen on client monitor #4. Since we send down absolute positions and disable alignment when all windows are in fullscreen, we can send configurations with a very large offset to the top-left corner. This could result in the guest trying to create a screen that was much larger than necessary. For example when sending a configuration of 1280x1024+4240+0, the guest would need to allocate a screen of size 5520x1024, which might fail if video memory was too low. To avoid this issue, we shift all displays so that the minimum X coordinate for all screens is at x=0, and the minimum y coordinate is at y=0.
* Move monitor alignment function to util headerJonathon Jongsma2014-10-243-50/+54
|
* man: Improve documentation for 'version' field in vv filesChristophe Fergeau2014-10-231-2/+6
|
* spec: Update/optimize mime scriptletsRex Dieter2014-10-231-4/+5
|
generated by cgit (git 2.34.1) at 2025-09-25 19:06:09 +0000