summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorFabiano FidĂȘncio <fidencio@redhat.com>2014-11-19 05:26:58 +0100
committerFabiano FidĂȘncio <fidencio@redhat.com>2014-11-20 11:15:05 +0100
commitde8b381fa4bc5452ca444d30356d57ec69949f34 (patch)
treed603b7ad2706175a3b8d5f001ba2d07d6fd6703c /src
parent1c69f3cf40e0e44f4d5a1bb20e432fc0ee0a97ea (diff)
Make sure conn exists before use it
Although all the used functions have a explicit check for a valid virConnPtr, let's be safe and only use priv->conn when its value is non-NULL.
Diffstat (limited to 'src')
-rw-r--r--src/virt-viewer.c16
1 files changed, 9 insertions, 7 deletions
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index dc16b3f..02385db 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -529,15 +529,17 @@ virt_viewer_dispose (GObject *object)
VirtViewer *self = VIRT_VIEWER(object);
VirtViewerPrivate *priv = self->priv;
- if (priv->withEvents)
- virConnectDomainEventDeregister(priv->conn,
- virt_viewer_domain_event);
- virConnectUnregisterCloseCallback(priv->conn,
- virt_viewer_conn_event);
+ if (priv->conn) {
+ if (priv->withEvents)
+ virConnectDomainEventDeregister(priv->conn,
+ virt_viewer_domain_event);
+ virConnectUnregisterCloseCallback(priv->conn,
+ virt_viewer_conn_event);
+ virConnectClose(priv->conn);
+ priv->conn = NULL;
+ }
if (priv->dom)
virDomainFree(priv->dom);
- if (priv->conn)
- virConnectClose(priv->conn);
g_free(priv->uri);
priv->uri = NULL;
g_free(priv->domkey);