diff options
author | Marc-André Lureau <marcandre.lureau@gmail.com> | 2014-11-13 18:20:42 +0100 |
---|---|---|
committer | Marc-André Lureau <marcandre.lureau@gmail.com> | 2014-11-25 13:00:50 +0100 |
commit | 6100d08dd328564551e3d791d9c56c3062eeced7 (patch) | |
tree | 82569292ec9f641051cb71d0fdf7755718dc0551 /src/virt-viewer.c | |
parent | 9e2f9ea0643c18a7d8a499fc0391b7daf06abbd0 (diff) | |
download | virt-viewer-6100d08dd328564551e3d791d9c56c3062eeced7.tar.gz virt-viewer-6100d08dd328564551e3d791d9c56c3062eeced7.tar.xz virt-viewer-6100d08dd328564551e3d791d9c56c3062eeced7.zip |
Simplify virt_viewer_initial_connect()
- do not overwrite err if ->initial_connect() sets it
- remove need for waitvm if the display server isn't yet started (note:
this function might be untested, I am not sure relying on libvirt events
is enough)
Diffstat (limited to 'src/virt-viewer.c')
-rw-r--r-- | src/virt-viewer.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/virt-viewer.c b/src/virt-viewer.c index 1a64f84..883c823 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -684,13 +684,13 @@ virt_viewer_initial_connect(VirtViewerApp *app, GError **error) virt_viewer_app_show_status(app, _("Waiting for guest domain to start")); goto wait; } - ret = virt_viewer_update_display(self, dom); - if (ret) { - ret = VIRT_VIEWER_APP_CLASS(virt_viewer_parent_class)->initial_connect(app, &err); - if (!ret) { - virt_viewer_app_show_status(app, _("Waiting for guest domain to start server")); + + if (!virt_viewer_update_display(self, dom)) goto wait; - } + + ret = VIRT_VIEWER_APP_CLASS(virt_viewer_parent_class)->initial_connect(app, &err); + if (ret || err) + goto cleanup; wait: virt_viewer_app_trace(app, "Guest %s has not activated its display yet, waiting " |