diff options
| author | Jonathon Jongsma <jjongsma@redhat.com> | 2015-04-08 16:41:05 -0500 |
|---|---|---|
| committer | Fabiano Fidêncio <fidencio@redhat.com> | 2015-04-09 10:47:57 +0200 |
| commit | c543941a1795cabb75307d2e49237d03ddd3cb26 (patch) | |
| tree | 8fd2734416a1158577f0786a8d143e4f42cbf769 /src/virt-viewer-session-spice.c | |
| parent | 7ddbd28756f8a8aee7fffd5cbf3eaa678ce492b6 (diff) | |
| download | virt-viewer-c543941a1795cabb75307d2e49237d03ddd3cb26.tar.gz virt-viewer-c543941a1795cabb75307d2e49237d03ddd3cb26.tar.xz virt-viewer-c543941a1795cabb75307d2e49237d03ddd3cb26.zip | |
Cleanup: only add display when it's created
This wasn't causing any problems because the _add_display() function has
an early return for the case that the display has already been added to
the session, but it's quite confusing when reading the code to see this
_add_display() function being called for every display every time we get
a monitor configuration update.
Diffstat (limited to 'src/virt-viewer-session-spice.c')
| -rw-r--r-- | src/virt-viewer-session-spice.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c index ccd869e..da193ec 100644 --- a/src/virt-viewer-session-spice.c +++ b/src/virt-viewer-session-spice.c @@ -727,10 +727,9 @@ virt_viewer_session_spice_display_monitors(SpiceChannel *channel, display = virt_viewer_display_spice_new(self, channel, i); g_debug("creating spice display (#:%d)", i); g_ptr_array_index(displays, i) = g_object_ref_sink(display); + virt_viewer_session_add_display(VIRT_VIEWER_SESSION(self), + VIRT_VIEWER_DISPLAY(display)); } - - virt_viewer_session_add_display(VIRT_VIEWER_SESSION(self), - VIRT_VIEWER_DISPLAY(display)); } for (i = 0; i < monitors->len; i++) { |