summaryrefslogtreecommitdiffstats
path: root/spice-common
diff options
context:
space:
mode:
authorYonit Halperin <yhalperi@redhat.com>2012-07-25 14:16:41 +0300
committerYonit Halperin <yhalperi@redhat.com>2012-07-25 14:16:41 +0300
commitcf6e58fe334a550babaf325826782533512273b5 (patch)
tree3d9ec758cc412949cdbd4965db6f548245222c93 /spice-common
parentad7c5ca72a36a867c11409ebe55016a8da7b7441 (diff)
downloadspice-cf6e58fe334a550babaf325826782533512273b5.tar.gz
spice-cf6e58fe334a550babaf325826782533512273b5.tar.xz
spice-cf6e58fe334a550babaf325826782533512273b5.zip
red_worker: Fix reference counting for the current frame (drawable) of a stream
After marshalling MSG_STREAM_CREATE, there is no need to ref and unref stream->current before and after completing the sending of the message (correspondingly). The referencing is unnecessary because all the data that is required from the drawable (the clipping), is copied during marshalling, and no field in the drawable is referenced (see spice_marshall_msg_display_stream_create). Moreover, the referencing was bugous: While display_channel_hold_pipe_item and display_channel_client_release_item_after_push referenced and dereferenced, correspondingly, stream->current, stream->current might have changed in between these calls, and then we ended up with one drawable leaking, and one drawable released before its time has come (which of course led to critical errors).
Diffstat (limited to 'spice-common')
0 files changed, 0 insertions, 0 deletions