server/spicevmc: Don't destroy the rcc twice

spicevmc calls red_channel_client_destroy() on the rcc when it disconnects
since we don't want to delay the destroy until the session gets closed as
spicevmc channels can be opened, closed and opened again during a single
session.

This causes red_channel_client_destroy() to get called twice, triggering
an assert, when a connected channel gets destroyed.

This was fixed with commit ffc4de01e6f9ea0676f17b10e45a137d7e15d6ac for
the case where: a spicevmc channel was open on client disconnected, and
the main channel disconnect gets handled first.

But the channel can also be destroyed when the chardev gets unregistered
with the spice-server. This path still triggers the assert.

This patch fixes this by adding a destroying flag to the rcc struct, and
also moves the previous fix over to the same, more clean, method of
detecting this special case.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/server/spicevmc.c b/server/spicevmc.c
index 5cdc513e..30aaf2f4 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -116,9 +116,9 @@ static void spicevmc_red_channel_client_on_disconnect(RedChannelClient *rcc)
     sin = state->chardev_sin;
     sif = SPICE_CONTAINEROF(sin->base.sif, SpiceCharDeviceInterface, base);
 
-    /* Don't destroy the rcc if the entire client is disconnecting, as then
-       red_client_destroy will already do this! */
-    if (!rcc->client->disconnecting)
+    /* Don't destroy the rcc if it is already being destroyed, as then
+       red_client_destroy/red_channel_client_destroy will already do this! */
+    if (!rcc->destroying)
         red_channel_client_destroy(rcc);
 
     state->rcc = NULL;