diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2010-10-06 12:37:05 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2010-10-06 19:17:08 +0200 |
| commit | 7b84db7a7484b58fdde21029ef374baeaa0a4b51 (patch) | |
| tree | b60ecf190ce59021b7e57c3d4b9d4c076536ae9a /client/red_client.cpp | |
| parent | 34bfaa302d5da8e08620d31d3f40d55ee9d14b98 (diff) | |
| download | spice-7b84db7a7484b58fdde21029ef374baeaa0a4b51.tar.gz spice-7b84db7a7484b58fdde21029ef374baeaa0a4b51.tar.xz spice-7b84db7a7484b58fdde21029ef374baeaa0a4b51.zip | |
spicec: Move setting of clipboard_owner to guest to platform code
Atleast under x11 there is a race condition when setting the clipboard
owner to guest from the RedClient code rather then doing it in Platform.
After the XSetSelectionOwner() in Platform::on_clipboard_grab(), which runs
from the main message loop thread, the x11 event thread can receive a
SelectionRequest event from another x11 app, before the RedClient code
has set the clipboard owner, which will trigger the owner != guest
check in the SelectionRequest event handling code.
By moving the setting of the owner in to Platform::on_clipboard_grab() it
gets protected by the clipboard lock, which closes this tiny race.
Diffstat (limited to 'client/red_client.cpp')
| -rw-r--r-- | client/red_client.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/client/red_client.cpp b/client/red_client.cpp index 8e7dfe0e..0650e35a 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -1118,7 +1118,6 @@ void RedClient::dispatch_agent_message(VDAgentMessage* msg, void* data) case VD_AGENT_CLIPBOARD_GRAB: Platform::on_clipboard_grab((uint32_t *)data, msg->size / sizeof(uint32_t)); - Platform::set_clipboard_owner(Platform::owner_guest); break; case VD_AGENT_CLIPBOARD_REQUEST: if (Platform::get_clipboard_owner() != Platform::owner_client) { |