diff options
| author | Christophe Fergeau <cfergeau@redhat.com> | 2011-08-16 11:14:44 +0200 |
|---|---|---|
| committer | Christophe Fergeau <cfergeau@redhat.com> | 2011-08-17 10:42:18 +0200 |
| commit | f2b4c3d21aed0018dc7014542f76b64e6aa57ce6 (patch) | |
| tree | e9894d758dc274b55609c52e131b81bc28fe7dce /client/inputs_channel.cpp | |
| parent | 0d4bd55042391d7cbbc9f21725aba02e50174d5b (diff) | |
| download | spice-f2b4c3d21aed0018dc7014542f76b64e6aa57ce6.tar.gz spice-f2b4c3d21aed0018dc7014542f76b64e6aa57ce6.tar.xz spice-f2b4c3d21aed0018dc7014542f76b64e6aa57ce6.zip | |
fix harmless typo in InputsChannel::handle_modifiers
InputsChannel::handle_modifiers converts _modifiers which is a
bitflag of SPICE_KEYBOARD_MODIFIER_FLAGS_* to a Platform::*_MODIFIER
bitflag, which is what Platform::set_keyboard_lock_modifiers expects.
However, it's called with _modifiers, and the bitflag that this
function computes is never used. Pass the computed bitflag to
::set_keyboard_lock_modifiers since _modifiers format is meaningless
for ::set_keyboard_lock_modifiers.
This bug was harmless because the two different set of modifier
flags actually use the same values, so _modifiers and modifiers could
be used interchangeably. However it's more future-proof to use the
right format here.
Diffstat (limited to 'client/inputs_channel.cpp')
| -rw-r--r-- | client/inputs_channel.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/client/inputs_channel.cpp b/client/inputs_channel.cpp index 4d1232a3..9e940d9a 100644 --- a/client/inputs_channel.cpp +++ b/client/inputs_channel.cpp @@ -402,7 +402,7 @@ void InputsChannel::set_local_modifiers() modifiers |= Platform::CAPS_LOCK_MODIFIER; } - Platform::set_keyboard_lock_modifiers(_modifiers); + Platform::set_keyboard_lock_modifiers(modifiers); } void InputsChannel::on_focus_in() |