diff options
author | Frediano Ziglio <fziglio@redhat.com> | 2016-01-26 16:34:55 +0000 |
---|---|---|
committer | Frediano Ziglio <fziglio@redhat.com> | 2016-01-26 17:17:08 +0000 |
commit | 7790dacfd3fe0b6624f64260ed5e7375dcf06aae (patch) | |
tree | 2d019b9fa0f52d6df4e3fdb60a291b2e62aeb45f | |
parent | 5376f1d88c3aac5ae8f9d387aee61929f1840fa9 (diff) | |
download | spice-common-7790dacfd3fe0b6624f64260ed5e7375dcf06aae.tar.gz spice-common-7790dacfd3fe0b6624f64260ed5e7375dcf06aae.tar.xz spice-common-7790dacfd3fe0b6624f64260ed5e7375dcf06aae.zip |
small spice_strdup optimization
avoid to compute the string length twice and use memcpy instead of
strcpy which is faster not having to check for terminator.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
-rw-r--r-- | common/mem.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/common/mem.c b/common/mem.c index 2fda6f3..e430b5d 100644 --- a/common/mem.c +++ b/common/mem.c @@ -46,13 +46,15 @@ size_t spice_strnlen(const char *str, size_t max_len) char *spice_strdup(const char *str) { char *copy; + size_t len; if (str == NULL) { return NULL; } - copy = (char *)spice_malloc(strlen(str) + 1); - strcpy(copy, str); + len = strlen(str) + 1; + copy = (char *)spice_malloc(len); + memcpy(copy, str, len); return copy; } |