summaryrefslogtreecommitdiffstats
path: root/libmsi/libmsi-database.c
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@gmail.com>2012-12-12 01:33:12 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2013-01-09 13:56:06 +0100
commit6e9a50e37e51564c9d5f84e156c33af7e93cc2b8 (patch)
tree0ded25223d11088269a86d7100d83b74458e2e1a /libmsi/libmsi-database.c
parente14bf3cdcf43bce1592c950472b9f87b77fb2f39 (diff)
downloadmsitools-6e9a50e37e51564c9d5f84e156c33af7e93cc2b8.tar.gz
msitools-6e9a50e37e51564c9d5f84e156c33af7e93cc2b8.tar.xz
msitools-6e9a50e37e51564c9d5f84e156c33af7e93cc2b8.zip
query: return TRUE on success, add GError
Diffstat (limited to 'libmsi/libmsi-database.c')
-rw-r--r--libmsi/libmsi-database.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/libmsi/libmsi-database.c b/libmsi/libmsi-database.c
index fe91d7b..6dafe66 100644
--- a/libmsi/libmsi-database.c
+++ b/libmsi/libmsi-database.c
@@ -953,6 +953,7 @@ static unsigned msi_add_table_to_db(LibmsiDatabase *db, char **columns, char **t
char *prelude;
char *columns_sql;
char *postlude;
+ GError *error = NULL; // FIXME: move error handling to caller
prelude = msi_build_createsql_prelude(labels[0]);
columns_sql = msi_build_createsql_columns(columns, types, num_columns);
@@ -975,10 +976,14 @@ static unsigned msi_add_table_to_db(LibmsiDatabase *db, char **columns, char **t
goto done;
r = _libmsi_query_execute(view, NULL);
- libmsi_query_close(view);
- g_object_unref(view);
+ libmsi_query_close(view, &error);
+ if (error) {
+ g_critical ("%s", error->message);
+ g_clear_error (&error);
+ }
done:
+ g_object_unref(view);
msi_free(prelude);
msi_free(columns_sql);
msi_free(postlude);