summaryrefslogtreecommitdiffstats
path: root/src/bind.c
diff options
context:
space:
mode:
authorAris Adamantiadis <aris@0xbadc0de.be>2014-02-05 21:24:12 +0100
committerAris Adamantiadis <aris@0xbadc0de.be>2014-03-04 09:54:25 +0100
commit48f0bfc70363ca31c8889ca68759e587bc6d7cbd (patch)
tree57bc7d4da024be3bfce56749daccb1dd1faabf33 /src/bind.c
parent87549f7bb6a570481f377e628001a04175f7d3a5 (diff)
downloadlibssh-v0-5.tar.gz
libssh-v0-5.tar.xz
libssh-v0-5.zip
security: fix for vulnerability CVE-2014-0017v0-5
When accepting a new connection, a forking server based on libssh forks and the child process handles the request. The RAND_bytes() function of openssl doesn't reset its state after the fork, but simply adds the current process id (getpid) to the PRNG state, which is not guaranteed to be unique. This can cause several children to end up with same PRNG state which is a security issue. Conflicts: src/bind.c
Diffstat (limited to 'src/bind.c')
-rw-r--r--src/bind.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/bind.c b/src/bind.c
index cc79f8eb..cdcdabe1 100644
--- a/src/bind.c
+++ b/src/bind.c
@@ -374,7 +374,8 @@ int ssh_bind_accept(ssh_bind sshbind, ssh_session session) {
ssh_socket_get_poll_handle_out(session->socket);
session->dsa_key = dsa;
session->rsa_key = rsa;
-
+ /* force PRNG to change state in case we fork after ssh_bind_accept */
+ ssh_reseed();
return SSH_OK;
}