diff options
| author | jdennis <jdennis@c9f7a03b-bd48-0410-a16d-cbbf54688b0b> | 2010-11-19 20:37:37 +0000 |
|---|---|---|
| committer | jdennis <jdennis@c9f7a03b-bd48-0410-a16d-cbbf54688b0b> | 2010-11-19 20:37:37 +0000 |
| commit | 8a52e6243118380c747a6bea76431a21cb4ece6a (patch) | |
| tree | b96164e505c46ebbe34c5fa2b11766f4a542c538 /pki/base/silent/src/http/HTTPClient.java | |
| parent | 16593c151fb90095f631095f9967a217762e1c49 (diff) | |
Parameter list style fix
The preferred canonical style for Perl subroutine parameter lists is
to write the parameter list as an actual parameter list prefixed by
the "my" lexical modifier and initialized from the @_ parameter
array. The parameter list should be the first line in the sub. This
makes it much easier to read the code because a parameter list looks
like a parameter list. This improves readability and follows widely
adopted style conventions. For example:
sub foo
{
my ($able, $baker) = @_;
}
Thus the signature for this subroutine is:
foo($able, $baker)
The patch also removes comments of the form
# arg0 is able
# arg1 is baker
Which are silly when you write the parameter list to look like a
parameter list because it's self evident what the parameters
are. Comments like that clutter the code, decreases readability and
does not add any information content.
git-svn-id: svn+ssh://svn.fedorahosted.org/svn/pki/trunk@1541 c9f7a03b-bd48-0410-a16d-cbbf54688b0b
Diffstat (limited to 'pki/base/silent/src/http/HTTPClient.java')
0 files changed, 0 insertions, 0 deletions
