Refactored UpdateCRL.process() (part 1).

The UpdateCRL.process() has been refactored to reduce deeply
nested if-statements with early return.

https://pagure.io/dogtagpki/issue/2651

Change-Id: I507bf72e28c3ba0ab98f24466bac2a40f1e6b198

1 files changed, 5 insertions, 3 deletions

diff --git a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
index d873b1a33..118292220 100644
--- a/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
+++ b/base/server/cms/src/com/netscape/cms/servlet/cert/UpdateCRL.java
@@ -331,7 +331,11 @@ public class UpdateCRL extends CMSServlet {
         header.addStringValue("crlIssuingPoint", crlIssuingPointId);
         IPublisherProcessor lpm = mCA.getPublisherProcessor();
 
-        if (crlIssuingPoint != null) {
+        if (crlIssuingPoint == null) {
+            CMS.debug("UpdateCRL: no CRL issuing point");
+            return;
+        }
+
             if (clearCache != null && clearCache.equals("true") &&
                     crlIssuingPoint.isCRLGenerationEnabled() &&
                     crlIssuingPoint.isCRLUpdateInProgress() == ICRLIssuingPoint.CRL_UPDATE_DONE &&
@@ -523,7 +527,5 @@ public class UpdateCRL extends CMSServlet {
                     header.addStringValue("crlUpdate", "Scheduled");
                 }
             }
-        }
-        return;
     }
 }