Fixed resource leak in OCSPNoCheckExtension.

The OCSPNoCheckExtension has been modified to always close the
DerOutputStream instance.

The OCSPNoCheckExt has been modified to wrap the original
exception.

https://fedorahosted.org/pki/ticket/2530

1 files changed, 4 insertions, 2 deletions

diff --git a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
index 3d89e1d50..5952a29b8 100644
--- a/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
+++ b/base/util/src/netscape/security/extensions/OCSPNoCheckExtension.java
@@ -51,11 +51,11 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet {
         }
     }
 
-    public OCSPNoCheckExtension() {
+    public OCSPNoCheckExtension() throws IOException {
         this(Boolean.FALSE);
     }
 
-    public OCSPNoCheckExtension(Boolean crit) {
+    public OCSPNoCheckExtension(Boolean crit) throws IOException {
         try {
             extensionId = ObjectIdentifier.getObjectIdentifier(OCSPNoCheckExtension.OID);
         } catch (IOException e) {
@@ -67,6 +67,8 @@ public class OCSPNoCheckExtension extends Extension implements CertAttrSet {
         try {
             tmpD.putNull();
         } catch (IOException ex) {
+        } finally {
+            tmpD.close();
         }
         extensionValue = tmpD.toByteArray();
     }