diff options
author | Endi S. Dewata <edewata@redhat.com> | 2016-11-03 02:46:30 +0100 |
---|---|---|
committer | Endi S. Dewata <edewata@redhat.com> | 2016-11-04 00:02:04 +0100 |
commit | 2df13e14e79d048deb5865ad7752dd4a1300b195 (patch) | |
tree | ee71678b8ea6189da5bbb471a4d64d0dab12ae94 /base/util | |
parent | f570bc4d54af59eb9cbb29f672c2b7219e03f616 (diff) | |
download | pki-2df13e14e79d048deb5865ad7752dd4a1300b195.tar.gz pki-2df13e14e79d048deb5865ad7752dd4a1300b195.tar.xz pki-2df13e14e79d048deb5865ad7752dd4a1300b195.zip |
Fixed resource leak in InhibitAnyPolicyExtension.
The InhibitAnyPolicyExtension has been modified to always close
the DerOutputStream instance.
The InhibitAnyPolicyExtDefault has been modified to wrap the
original exception.
https://fedorahosted.org/pki/ticket/2530
Diffstat (limited to 'base/util')
-rw-r--r-- | base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java index 40b824fa4..87c19f384 100644 --- a/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java +++ b/base/util/src/netscape/security/extensions/InhibitAnyPolicyExtension.java @@ -61,11 +61,11 @@ public class InhibitAnyPolicyExtension } } - public InhibitAnyPolicyExtension() { + public InhibitAnyPolicyExtension() throws IOException { this(false, null); } - public InhibitAnyPolicyExtension(boolean crit, BigInt skipCerts) { + public InhibitAnyPolicyExtension(boolean crit, BigInt skipCerts) throws IOException { try { extensionId = ObjectIdentifier.getObjectIdentifier(OID); } catch (IOException e) { @@ -170,11 +170,13 @@ public class InhibitAnyPolicyExtension } } - private void encodeExtValue() { + private void encodeExtValue() throws IOException { DerOutputStream out = new DerOutputStream(); try { out.putInteger(mSkipCerts); } catch (IOException e) { + } finally { + out.close(); } extensionValue = out.toByteArray(); } |