diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-29 16:08:04 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-07-06 00:56:33 -0400 |
commit | 759d54747b779a1cb11f1b9fbfe8166e62dde03d (patch) | |
tree | b9164f3213d6a0923e8293772fb8362849f327b6 /base/util/src/netscape/security/x509/X509CertInfo.java | |
parent | 9ce810c0b2fef9f70178dbeee8a3523755a2a260 (diff) | |
download | pki-759d54747b779a1cb11f1b9fbfe8166e62dde03d.tar.gz pki-759d54747b779a1cb11f1b9fbfe8166e62dde03d.tar.xz pki-759d54747b779a1cb11f1b9fbfe8166e62dde03d.zip |
Coverity CATCH_REXCEPTION and UNREAD_FIELD_CASES
Diffstat (limited to 'base/util/src/netscape/security/x509/X509CertInfo.java')
-rw-r--r-- | base/util/src/netscape/security/x509/X509CertInfo.java | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/base/util/src/netscape/security/x509/X509CertInfo.java b/base/util/src/netscape/security/x509/X509CertInfo.java index 0c44e2c92..6ad4d243f 100644 --- a/base/util/src/netscape/security/x509/X509CertInfo.java +++ b/base/util/src/netscape/security/x509/X509CertInfo.java @@ -352,12 +352,13 @@ public class X509CertInfo implements CertAttrSet, Serializable { for (int i = 0; i < extensions.size(); i++) { sb.append(" Extension[" + i + "] = "); Extension ext = extensions.elementAt(i); + DerOutputStream out = null; try { if (OIDMap.getClass(ext.getExtensionId()) == null) { sb.append(ext.toString()); byte[] extValue = ext.getExtensionValue(); if (extValue != null) { - DerOutputStream out = new DerOutputStream(); + out = new DerOutputStream(); out.putOctetString(extValue); extValue = out.toByteArray(); String extValuebits = pp.toHexString(extValue); @@ -367,8 +368,18 @@ public class X509CertInfo implements CertAttrSet, Serializable { } } else sb.append(ext.toString()); //sub-class exists - } catch (Exception e) { + } catch (CertificateException e) { sb.append(", Error parsing this extension"); + } catch (IOException e) { + sb.append(", Error parsing this extension"); + } finally { + if (out != null) { + try { + out.close(); + } catch (IOException e) { + e.printStackTrace(); + } + } } } } |