diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-06-20 13:56:57 -0400 |
---|---|---|
committer | Endi Sukma Dewata <edewata@redhat.com> | 2012-06-25 13:38:26 -0500 |
commit | 8a8436f73d4c4edd10b43313b724f32ccb7b957e (patch) | |
tree | 657c8f9accd34d286acf0569f768c72684a12b75 /base/util/src/netscape/security/extensions/GenericASN1Extension.java | |
parent | de3aaef15e9b1f192344019f52d6c80860055b5e (diff) | |
download | pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.gz pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.tar.xz pki-8a8436f73d4c4edd10b43313b724f32ccb7b957e.zip |
Fixes for Coverity issues of type Resource Leaks - Remaining
Diffstat (limited to 'base/util/src/netscape/security/extensions/GenericASN1Extension.java')
-rw-r--r-- | base/util/src/netscape/security/extensions/GenericASN1Extension.java | 52 |
1 files changed, 29 insertions, 23 deletions
diff --git a/base/util/src/netscape/security/extensions/GenericASN1Extension.java b/base/util/src/netscape/security/extensions/GenericASN1Extension.java index 78d294573..b51846498 100644 --- a/base/util/src/netscape/security/extensions/GenericASN1Extension.java +++ b/base/util/src/netscape/security/extensions/GenericASN1Extension.java @@ -419,31 +419,37 @@ public class GenericASN1Extension extends Extension } FileInputStream fis = new FileInputStream(fname); - int n = 0; - while ((n = fis.available()) > 0) { - buff = new byte[n]; - int result = fis.read(buff); - if (result == -1) - break; - s = new String(buff); - } + try { + int n = 0; + while ((n = fis.available()) > 0) { + buff = new byte[n]; + int result = fis.read(buff); + if (result == -1) + break; + s = new String(buff); + } - for (i = 0, j = 0; j < s.length(); j++) { - int ch = s.charAt(j); - if (ch == 10 || ch == 13 || ch == 9) - continue; - i++; - } - buff = new byte[i]; - for (i = 0, j = 0; j < s.length(); j++) { - int ch = s.charAt(j); - if (ch == 10 || ch == 13 || ch == 9) - continue; - buff[i++] = (byte) ch; - } + for (i = 0, j = 0; j < s.length(); j++) { + int ch = s.charAt(j); + if (ch == 10 || ch == 13 || ch == 9) + continue; + i++; + } + buff = new byte[i]; + for (i = 0, j = 0; j < s.length(); j++) { + int ch = s.charAt(j); + if (ch == 10 || ch == 13 || ch == 9) + continue; + buff[i++] = (byte) ch; + } - s = new String(buff); + s = new String(buff); - return s; + return s; + } finally { + if (fis != null) { + fis.close(); + } + } } } |