summaryrefslogtreecommitdiffstats
path: root/base/silent
diff options
context:
space:
mode:
authorAbhishek Koneru <akoneru@redhat.com>2012-05-18 11:44:45 -0400
committerAde Lee <alee@redhat.com>2012-05-24 23:08:07 -0400
commita6fca9587905f455c4b0306b02d77334a295305e (patch)
treeeddf6a64341dafd126467d2abccdbbd7c8f05a72 /base/silent
parent739c50ee20704128e0bf4605ba7ca392d95070a2 (diff)
downloadpki-a6fca9587905f455c4b0306b02d77334a295305e.tar.gz
pki-a6fca9587905f455c4b0306b02d77334a295305e.tar.xz
pki-a6fca9587905f455c4b0306b02d77334a295305e.zip
Fixes for Coverity Defects of Category : FB.BC_VACUOUS_INSTANCEOF
Diffstat (limited to 'base/silent')
-rw-r--r--base/silent/src/com/netscape/pkisilent/common/CMSProperties.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java b/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
index e0f2d4516..241d13f06 100644
--- a/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
+++ b/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
@@ -553,11 +553,10 @@ class CMSProperties extends Hashtable<String, String> {
*/
public String getProperty(String key) {
String oval = super.get(key);
- String sval = (oval instanceof String) ? oval : null;
- return ((sval == null) && (defaults != null))
+ return ((oval == null) && (defaults != null))
? defaults.getProperty(key)
- : sval;
+ : oval;
}
/**