From a6fca9587905f455c4b0306b02d77334a295305e Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Fri, 18 May 2012 11:44:45 -0400
Subject: Fixes for Coverity Defects of Category : FB.BC_VACUOUS_INSTANCEOF

---
 base/silent/src/com/netscape/pkisilent/common/CMSProperties.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'base/silent')

diff --git a/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java b/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
index e0f2d4516..241d13f06 100644
--- a/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
+++ b/base/silent/src/com/netscape/pkisilent/common/CMSProperties.java
@@ -553,11 +553,10 @@ class CMSProperties extends Hashtable<String, String> {
      */
     public String getProperty(String key) {
         String oval = super.get(key);
-        String sval = (oval instanceof String) ? oval : null;
 
-        return ((sval == null) && (defaults != null))
+        return ((oval == null) && (defaults != null))
                 ? defaults.getProperty(key)
-                : sval;
+                : oval;
     }
 
     /**
-- 
cgit