diff options
| author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-18 17:59:50 -0400 |
|---|---|---|
| committer | Ade Lee <alee@redhat.com> | 2012-05-24 23:09:10 -0400 |
| commit | be23c86db27b7f66ca16a10ae3ef3f043d1d4b27 (patch) | |
| tree | ba5ed1bbe24889b7d22278093ee66cffc780b42b /base/silent/src/com/netscape/pkisilent/common/ComCrypto.java | |
| parent | 9db76ed1d1f8969e93aaff320e49662f53688e2e (diff) | |
| download | pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.gz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.tar.xz pki-be23c86db27b7f66ca16a10ae3ef3f043d1d4b27.zip | |
Fixes for Coverity Defects of Category : FB.SBSC_USE_STRINGBUFFER_CONCATENATION --Remaining
Diffstat (limited to 'base/silent/src/com/netscape/pkisilent/common/ComCrypto.java')
| -rw-r--r-- | base/silent/src/com/netscape/pkisilent/common/ComCrypto.java | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java index e36966de1..2dacaabbf 100644 --- a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java +++ b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java @@ -291,11 +291,11 @@ public class ComCrypto { public String normalize(String s) { - String val = ""; + StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) { - val += '\n'; + val.append('\n'); i++; continue; } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) { @@ -304,9 +304,9 @@ public class ComCrypto { } else if (s.charAt(i) == '"') { continue; } - val += s.charAt(i); + val.append(s.charAt(i)); } - return val; + return val.toString(); } /** @@ -315,11 +315,11 @@ public class ComCrypto { public String normalizeForLDAP(String s) { - String val = ""; + StringBuffer val = new StringBuffer(); for (int i = 0; i < s.length(); i++) { if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) { - val += '\n' + " "; + val.append(System.getProperty("line.separator") + " "); i++; continue; } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) { @@ -328,9 +328,9 @@ public class ComCrypto { } else if (s.charAt(i) == '"') { continue; } - val += s.charAt(i); + val.append(s.charAt(i)); } - return val; + return val.toString(); } /** @@ -339,20 +339,20 @@ public class ComCrypto { public String pkcs7Convertcert(String s) { - String val = ""; + StringBuffer val = new StringBuffer(); int len = s.length(); for (int i = 0; i < len; i = i + 64) { if (i + 64 < len) { - val = val + s.substring(i, i + 64) + "\n"; + val.append(s.substring(i, i + 64)+System.getProperty("line.separator")); } else { - val = val + s.substring(i, len); + val.append(s.substring(i, len)); } } - return val; + return val.toString(); } /** |