From be23c86db27b7f66ca16a10ae3ef3f043d1d4b27 Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Fri, 18 May 2012 17:59:50 -0400
Subject: Fixes for Coverity Defects of Category :
 FB.SBSC_USE_STRINGBUFFER_CONCATENATION --Remaining

---
 .../com/netscape/pkisilent/common/ComCrypto.java   | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

(limited to 'base/silent/src/com/netscape/pkisilent/common/ComCrypto.java')

diff --git a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java
index e36966de1..2dacaabbf 100644
--- a/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java
+++ b/base/silent/src/com/netscape/pkisilent/common/ComCrypto.java
@@ -291,11 +291,11 @@ public class ComCrypto {
 
     public String normalize(String s) {
 
-        String val = "";
+        StringBuffer val = new StringBuffer();
 
         for (int i = 0; i < s.length(); i++) {
             if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) {
-                val += '\n';
+                val.append('\n');
                 i++;
                 continue;
             } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) {
@@ -304,9 +304,9 @@ public class ComCrypto {
             } else if (s.charAt(i) == '"') {
                 continue;
             }
-            val += s.charAt(i);
+            val.append(s.charAt(i));
         }
-        return val;
+        return val.toString();
     }
 
     /**
@@ -315,11 +315,11 @@ public class ComCrypto {
 
     public String normalizeForLDAP(String s) {
 
-        String val = "";
+        StringBuffer val = new StringBuffer();
 
         for (int i = 0; i < s.length(); i++) {
             if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'n')) {
-                val += '\n' + " ";
+                val.append(System.getProperty("line.separator") + " ");
                 i++;
                 continue;
             } else if ((s.charAt(i) == '\\') && (s.charAt(i + 1) == 'r')) {
@@ -328,9 +328,9 @@ public class ComCrypto {
             } else if (s.charAt(i) == '"') {
                 continue;
             }
-            val += s.charAt(i);
+            val.append(s.charAt(i));
         }
-        return val;
+        return val.toString();
     }
 
     /**
@@ -339,20 +339,20 @@ public class ComCrypto {
 
     public String pkcs7Convertcert(String s) {
 
-        String val = "";
+        StringBuffer val = new StringBuffer();
 
         int len = s.length();
 
         for (int i = 0; i < len; i = i + 64) {
 
             if (i + 64 < len) {
-                val = val + s.substring(i, i + 64) + "\n";
+                val.append(s.substring(i, i + 64)+System.getProperty("line.separator"));
             } else {
-                val = val + s.substring(i, len);
+                val.append(s.substring(i, len));
             }
 
         }
-        return val;
+        return val.toString();
     }
 
     /**
-- 
cgit