summaryrefslogtreecommitdiffstats
path: root/base/server/cmscore/src/com
diff options
context:
space:
mode:
authorEndi S. Dewata <edewata@redhat.com>2017-06-24 04:11:41 +0200
committerEndi S. Dewata <edewata@redhat.com>2017-06-27 07:32:52 +0200
commitc297d987d29755452b192ae1306610733381771a (patch)
tree0d82696414176bcaf888a958689047a04f148bbc /base/server/cmscore/src/com
parent388254c3f529647ce414d19e81e15aafb774eb41 (diff)
downloadpki-c297d987d29755452b192ae1306610733381771a.tar.gz
pki-c297d987d29755452b192ae1306610733381771a.tar.xz
pki-c297d987d29755452b192ae1306610733381771a.zip
Consolidated log() for audit events.
Duplicate log() methods for audit events have been merged into the Logger class. https://pagure.io/dogtagpki/issue/2689 Change-Id: I7a5147ff3221a52a82e69f56faf2156c04256db2
Diffstat (limited to 'base/server/cmscore/src/com')
-rw-r--r--base/server/cmscore/src/com/netscape/cmscore/cert/CertUtils.java12
-rw-r--r--base/server/cmscore/src/com/netscape/cmscore/logging/Auditor.java21
-rw-r--r--base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java11
3 files changed, 6 insertions, 38 deletions
diff --git a/base/server/cmscore/src/com/netscape/cmscore/cert/CertUtils.java b/base/server/cmscore/src/com/netscape/cmscore/cert/CertUtils.java
index 7519d6274..d80723783 100644
--- a/base/server/cmscore/src/com/netscape/cmscore/cert/CertUtils.java
+++ b/base/server/cmscore/src/com/netscape/cmscore/cert/CertUtils.java
@@ -43,6 +43,7 @@ import com.netscape.certsrv.base.EBaseException;
import com.netscape.certsrv.base.IConfigStore;
import com.netscape.certsrv.logging.AuditEvent;
import com.netscape.certsrv.logging.ILogger;
+import com.netscape.certsrv.logging.LogEvent;
import com.netscape.cms.logging.Logger;
import com.netscape.cms.logging.SignedAuditLogger;
import com.netscape.cmsutil.util.Utils;
@@ -1095,14 +1096,7 @@ public class CertUtils {
signedAuditLogger.log(msg);
}
- protected void audit(AuditEvent event) {
-
- String template = event.getMessage();
- Object[] params = event.getParameters();
-
- String message = CMS.getLogMessage(template, params);
-
- audit(message);
+ protected void audit(LogEvent event) {
+ signedAuditLogger.log(event);
}
-
}
diff --git a/base/server/cmscore/src/com/netscape/cmscore/logging/Auditor.java b/base/server/cmscore/src/com/netscape/cmscore/logging/Auditor.java
index 339f4dc63..a711dd116 100644
--- a/base/server/cmscore/src/com/netscape/cmscore/logging/Auditor.java
+++ b/base/server/cmscore/src/com/netscape/cmscore/logging/Auditor.java
@@ -24,13 +24,10 @@ import java.util.Map;
import com.netscape.certsrv.apps.CMS;
import com.netscape.certsrv.base.SessionContext;
import com.netscape.certsrv.common.Constants;
-import com.netscape.certsrv.logging.AuditEvent;
import com.netscape.certsrv.logging.IAuditor;
import com.netscape.certsrv.logging.ILogger;
import com.netscape.certsrv.usrgrp.IGroup;
import com.netscape.certsrv.usrgrp.IUGSubsystem;
-import com.netscape.cms.logging.Logger;
-import com.netscape.cms.logging.SignedAuditLogger;
/**
* @author Endi S. Dewata
@@ -39,8 +36,6 @@ public class Auditor implements IAuditor {
public final static Auditor auditor = new Auditor();
- private static Logger signedAuditLogger = SignedAuditLogger.getLogger();
-
public static IAuditor getAuditor() {
return auditor;
}
@@ -201,20 +196,4 @@ public class Auditor implements IAuditor {
return parameters.toString();
}
-
- @Override
- public void log(String message) {
- signedAuditLogger.log(message);
- }
-
- @Override
- public void log(AuditEvent event) {
-
- String template = event.getMessage();
- Object[] params = event.getParameters();
-
- String message = CMS.getLogMessage(template, params);
-
- log(message);
- }
}
diff --git a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
index c95994c74..fa38eac52 100644
--- a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
+++ b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java
@@ -41,6 +41,7 @@ import com.netscape.certsrv.logging.AuditEvent;
import com.netscape.certsrv.logging.ELogException;
import com.netscape.certsrv.logging.ILogEventListener;
import com.netscape.certsrv.logging.ILogger;
+import com.netscape.certsrv.logging.LogEvent;
import com.netscape.certsrv.selftests.EDuplicateSelfTestException;
import com.netscape.certsrv.selftests.EInvalidSelfTestException;
import com.netscape.certsrv.selftests.EMissingSelfTestException;
@@ -121,14 +122,8 @@ public class SelfTestSubsystem
signedAuditLogger.log(msg);
}
- protected void audit(AuditEvent event) {
-
- String template = event.getMessage();
- Object[] params = event.getParameters();
-
- String message = CMS.getLogMessage(template, params);
-
- audit(message);
+ protected void audit(LogEvent event) {
+ signedAuditLogger.log(event);
}
/**