diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2012-05-24 16:11:53 -0400 |
---|---|---|
committer | Ade Lee <alee@redhat.com> | 2012-06-01 09:35:27 -0400 |
commit | 2588e04ce15d8ce932900cb7b5d75e894082db46 (patch) | |
tree | 43776fbb3fb8b9a5656d3fdee1b2da90526a0eeb /base/common/src/com/netscape/cmscore/ldapconn | |
parent | b6967b3b2b850e4158bd1fb6cee418e714053e30 (diff) | |
download | pki-2588e04ce15d8ce932900cb7b5d75e894082db46.tar.gz pki-2588e04ce15d8ce932900cb7b5d75e894082db46.tar.xz pki-2588e04ce15d8ce932900cb7b5d75e894082db46.zip |
Fixes for Coverity Issues CALL_SUPER,UNCONFIRMEDCAST,DEAD_STORE,TOSTRING_ARRAY
Diffstat (limited to 'base/common/src/com/netscape/cmscore/ldapconn')
-rw-r--r-- | base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java | 9 | ||||
-rw-r--r-- | base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java | 9 |
2 files changed, 16 insertions, 2 deletions
diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java index 1edee3812..79f2e91c4 100644 --- a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java +++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java @@ -338,8 +338,15 @@ public class LdapAnonConnFactory implements ILdapConnFactory { if (conn == null) { return; } + AnonConnection anon = null; + // check if conn is valid and from this factory. - AnonConnection anon = (AnonConnection) conn; + if (conn instanceof AnonConnection) { + anon = (AnonConnection) conn; + } else { + log(ILogger.LL_WARN, "returnConn : Connection is not an AnonConnection"); + return; + } if (anon.getFacId() != mConns) { // returning a connection not from this factory. diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java index 1da965a3a..c3e84f136 100644 --- a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java +++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java @@ -413,7 +413,14 @@ public class LdapBoundConnFactory implements ILdapBoundConnFactory { if (conn == null) { return; } - BoundConnection boundconn = (BoundConnection) conn; + BoundConnection boundconn = null; + + if (conn instanceof BoundConnection) { + boundconn = (BoundConnection) conn; + } else { + log(ILogger.LL_WARN, "returnConn : Connection is not an BoundConnection"); + return; + } if (boundconn.getFacId() != mConns) { log(ILogger.LL_WARN, "returnConn: unknown connection."); |