From 2588e04ce15d8ce932900cb7b5d75e894082db46 Mon Sep 17 00:00:00 2001 From: Abhishek Koneru Date: Thu, 24 May 2012 16:11:53 -0400 Subject: Fixes for Coverity Issues CALL_SUPER,UNCONFIRMEDCAST,DEAD_STORE,TOSTRING_ARRAY --- .../src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java | 9 ++++++++- .../src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java | 9 ++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) (limited to 'base/common/src/com/netscape/cmscore/ldapconn') diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java index 1edee3812..79f2e91c4 100644 --- a/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java +++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapAnonConnFactory.java @@ -338,8 +338,15 @@ public class LdapAnonConnFactory implements ILdapConnFactory { if (conn == null) { return; } + AnonConnection anon = null; + // check if conn is valid and from this factory. - AnonConnection anon = (AnonConnection) conn; + if (conn instanceof AnonConnection) { + anon = (AnonConnection) conn; + } else { + log(ILogger.LL_WARN, "returnConn : Connection is not an AnonConnection"); + return; + } if (anon.getFacId() != mConns) { // returning a connection not from this factory. diff --git a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java index 1da965a3a..c3e84f136 100644 --- a/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java +++ b/base/common/src/com/netscape/cmscore/ldapconn/LdapBoundConnFactory.java @@ -413,7 +413,14 @@ public class LdapBoundConnFactory implements ILdapBoundConnFactory { if (conn == null) { return; } - BoundConnection boundconn = (BoundConnection) conn; + BoundConnection boundconn = null; + + if (conn instanceof BoundConnection) { + boundconn = (BoundConnection) conn; + } else { + log(ILogger.LL_WARN, "returnConn : Connection is not an BoundConnection"); + return; + } if (boundconn.getFacId() != mConns) { log(ILogger.LL_WARN, "returnConn: unknown connection."); -- cgit