diff options
author | Abhishek Koneru <akoneru@redhat.com> | 2013-07-17 14:21:30 -0400 |
---|---|---|
committer | Abhishek Koneru <akoneru@redhat.com> | 2013-07-18 11:40:31 -0400 |
commit | c1bdf93bd774a7a8553afd9fe3cabd25be0a2b2e (patch) | |
tree | 0fb58115ab73ac027aaa04fecd9786d2a8890122 /base/common/python/pki/encoder.py | |
parent | 9b83091ec85a2f0afaf2936ed6388b2ee53ef656 (diff) | |
download | pki-c1bdf93bd774a7a8553afd9fe3cabd25be0a2b2e.tar.gz pki-c1bdf93bd774a7a8553afd9fe3cabd25be0a2b2e.tar.xz pki-c1bdf93bd774a7a8553afd9fe3cabd25be0a2b2e.zip |
Fixes for issues reported by pylint.
Fixed the warning W0202 - attributes defined outside init and
error E0202 - An instance attribute hiding a method (which is actually
an error in json.encoder.JSONEncoder line 157.)
Diffstat (limited to 'base/common/python/pki/encoder.py')
-rw-r--r-- | base/common/python/pki/encoder.py | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/base/common/python/pki/encoder.py b/base/common/python/pki/encoder.py index 8d8a9c101..e947bbc7c 100644 --- a/base/common/python/pki/encoder.py +++ b/base/common/python/pki/encoder.py @@ -12,6 +12,23 @@ class CustomTypeEncoder(json.JSONEncoder): type to which the object belongs. That single key maps to another object literal which is just the __dict__ of the object encoded.""" + """Reason for ignoring the error + E0202 - An attribute affected in json.encoder line 157 hide this method + reported by pylint: + + The error is in json.encoder.JSONEncoder class. + There is a default method (which is overridden here) and also a class attribute + self.default initialized in the init method of the class. + The intention of such usage being that a custom default method object can + be passed to init when creating an instance of JSONEncoder, which is then assigned + to class's default method. (which is valid) + But pylint raises an issue due to the usage of same name for a method and an attribute + in which case the attribute definition hides the method. + The reason and example for the issue: (top rated comment) + http://stackoverflow.com/questions/12949064/python-what-happens- + when-instance-variable-name-is-same-as-method-name + """ + # pylint: disable-msg=E0202 def default(self, obj): for k, v in TYPES.items(): if isinstance(obj, v): |