diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2017-05-17 22:06:38 +0200 |
|---|---|---|
| committer | Endi S. Dewata <edewata@redhat.com> | 2017-05-17 22:37:12 +0200 |
| commit | 0b32d55d6c41dcdfbd63840a6681b12ad6675946 (patch) | |
| tree | c1c7127c211dd2b4c254ea5ae1c50003cca7d0b2 /base/ca | |
| parent | 579ed7eed16c9fc6e02928f71656d2a326d68c22 (diff) | |
| download | pki-0b32d55d6c41dcdfbd63840a6681b12ad6675946.tar.gz pki-0b32d55d6c41dcdfbd63840a6681b12ad6675946.tar.xz pki-0b32d55d6c41dcdfbd63840a6681b12ad6675946.zip | |
Refactored RevocationRequestListener.accept().
The RevocationRequestListener.accept() has been refactored to
reduce deeply nested if-statements with early return.
https://pagure.io/dogtagpki/issue/2651
Change-Id: I11dac11f05a4e3626043f4cfa56feacf01e6d5dd
Diffstat (limited to 'base/ca')
| -rw-r--r-- | base/ca/src/com/netscape/ca/CRLIssuingPoint.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java index a593eb897..d1053868a 100644 --- a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java +++ b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java @@ -3068,10 +3068,13 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable { public void accept(IRequest r) { String requestType = r.getRequestType(); - if (requestType.equals(IRequest.REVOCATION_REQUEST) || + if (!(requestType.equals(IRequest.REVOCATION_REQUEST) || requestType.equals(IRequest.UNREVOCATION_REQUEST) || requestType.equals(IRequest.CLA_CERT4CRL_REQUEST) || - requestType.equals(IRequest.CLA_UNCERT4CRL_REQUEST)) { + requestType.equals(IRequest.CLA_UNCERT4CRL_REQUEST))) { + return; + } + CMS.debug("Revocation listener called."); // check if serial number is in begin/end range if set. if (mBeginSerial != null || mEndSerial != null) { @@ -3136,7 +3139,6 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable { CMS.getUserMessage("CMS_BASE_INTERNAL_ERROR", e.toString()))); } } - } } } } |