Refactored signed audit logger.

Signed audit logger creation has been simplified into:

  Logger signedAuditLogger = SignedAuditLogger.getLogger();

The null checks on signed audit logger have been removed since
it cannot be null. Audit messages can be logged as follows:

  signedAuditLogger.log(message);

https://pagure.io/dogtagpki/issue/2689

Change-Id: I3bf781b0194a6cbb166f71751c098d1c2a3a657a

1 files changed, 6 insertions, 10 deletions

diff --git a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
index be6ffa877..984971513 100644
--- a/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
+++ b/base/ca/src/com/netscape/ca/CRLIssuingPoint.java
@@ -64,6 +64,8 @@ import com.netscape.certsrv.request.IRequestQueue;
 import com.netscape.certsrv.request.IRequestVirtualList;
 import com.netscape.certsrv.request.RequestId;
 import com.netscape.certsrv.util.IStatsSubsystem;
+import com.netscape.cms.logging.Logger;
+import com.netscape.cms.logging.SignedAuditLogger;
 import com.netscape.cmscore.dbs.CRLIssuingPointRecord;
 import com.netscape.cmscore.dbs.CertRecord;
 import com.netscape.cmscore.dbs.CertificateRepository;
@@ -106,6 +108,9 @@ import netscape.security.x509.X509CertImpl;
 
 public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
 
+    private static ILogger mLogger = CMS.getLogger();
+    private static Logger signedAuditLogger = SignedAuditLogger.getLogger();
+
     /* Foreign config param for IssuingDistributionPointExtension. */
     public static final String PROP_CACERTS = "onlyContainsCACerts";
 
@@ -120,8 +125,6 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
 
     public IPublisherProcessor mPublisherProcessor = null;
 
-    private ILogger mLogger = CMS.getLogger();
-
     private IConfigStore mConfigStore;
 
     private int mCountMod = 0;
@@ -3189,19 +3192,12 @@ public class CRLIssuingPoint implements ICRLIssuingPoint, Runnable {
 
     void audit(AuditEvent event) {
 
-        ILogger logger = CMS.getSignedAuditLogger();
-        if (logger == null) return;
-
         String messageID = event.getMessage();
         Object[] params = event.getParameters();
 
         String message = CMS.getLogMessage(messageID, params);
 
-        logger.log(ILogger.EV_SIGNED_AUDIT,
-                null,
-                ILogger.S_SIGNED_AUDIT,
-                ILogger.LL_SECURITY,
-                message);
+        signedAuditLogger.log(message);
     }
 }