Removed unnecessary EBaseException constructor.

The EBaseException(String msgFormat, String param) constructor has
been removed because it's only used once and can be substituted
with another constructor. All subclasses of EBaseException have
been updated accordingly.

https://fedorahosted.org/pki/ticket/915

17 files changed, 1 insertions, 160 deletions

diff --git a/base/common/src/com/netscape/certsrv/authentication/EAuthException.java b/base/common/src/com/netscape/certsrv/authentication/EAuthException.java
index 94240fdcc..18743c5e7 100644
--- a/base/common/src/com/netscape/certsrv/authentication/EAuthException.java
+++ b/base/common/src/com/netscape/certsrv/authentication/EAuthException.java
@@ -47,17 +47,6 @@ public class EAuthException extends EBaseException {
     }
 
     /**
-     * Constructs an authentication exception with a parameter.
-     * <p>
-     *
-     * @param msgFormat exception details in message string format
-     * @param param message string parameter
-     */
-    public EAuthException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
      * Constructs a auth exception with a exception parameter.
      * <P>
      *
diff --git a/base/common/src/com/netscape/certsrv/authorization/EAuthzException.java b/base/common/src/com/netscape/certsrv/authorization/EAuthzException.java
index ccb81f244..3674c8e00 100644
--- a/base/common/src/com/netscape/certsrv/authorization/EAuthzException.java
+++ b/base/common/src/com/netscape/certsrv/authorization/EAuthzException.java
@@ -47,17 +47,6 @@ public class EAuthzException extends EBaseException {
     }
 
     /**
-     * Constructs a authz exception with a parameter.
-     * <p>
-     *
-     * @param msgFormat exception details in message string format
-     * @param param message string parameter
-     */
-    public EAuthzException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
      * Constructs a authz exception with a exception parameter.
      * <P>
      *
diff --git a/base/common/src/com/netscape/certsrv/base/BadRequestDataException.java b/base/common/src/com/netscape/certsrv/base/BadRequestDataException.java
index 268221eae..d029cd4a7 100644
--- a/base/common/src/com/netscape/certsrv/base/BadRequestDataException.java
+++ b/base/common/src/com/netscape/certsrv/base/BadRequestDataException.java
@@ -16,9 +16,4 @@ public class BadRequestDataException extends EBaseException {
     public BadRequestDataException(String msgFormat, Object[] params) {
         super(msgFormat, params);
     }
-
-    public BadRequestDataException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
 }
diff --git a/base/common/src/com/netscape/certsrv/base/EBaseException.java b/base/common/src/com/netscape/certsrv/base/EBaseException.java
index 0ce8fdc3d..140a6acbc 100644
--- a/base/common/src/com/netscape/certsrv/base/EBaseException.java
+++ b/base/common/src/com/netscape/certsrv/base/EBaseException.java
@@ -63,24 +63,6 @@ public class EBaseException extends Exception {
     }
 
     /**
-     * Constructs an instance of this exception with the given resource key
-     * and a parameter as a string.
-     *
-     * <PRE>
-     * new EBaseException(BaseResource.NO_CONFIG_FILE, fileName);
-     * </PRE>
-     * <P>
-     *
-     * @param msgFormat exception details in message string format
-     * @param param message string parameter
-     */
-    public EBaseException(String msgFormat, String param) {
-        super(msgFormat);
-        mParams = new String[1];
-        mParams[0] = param;
-    }
-
-    /**
      * Constructs an instance of the exception given the resource key and
      * a exception parameter.
      *
diff --git a/base/common/src/com/netscape/certsrv/ca/ECAException.java b/base/common/src/com/netscape/certsrv/ca/ECAException.java
index 54ddbe806..01c601e98 100644
--- a/base/common/src/com/netscape/certsrv/ca/ECAException.java
+++ b/base/common/src/com/netscape/certsrv/ca/ECAException.java
@@ -51,17 +51,6 @@ public class ECAException extends EBaseException {
      * <P>
      *
      * @param msgFormat constant from CAResources.
-     * @param param additional parameters to the message.
-     */
-    public ECAException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a CA exception.
-     * <P>
-     *
-     * @param msgFormat constant from CAResources.
      * @param e embedded exception.
      */
     public ECAException(String msgFormat, Exception e) {
diff --git a/base/common/src/com/netscape/certsrv/dbs/EDBException.java b/base/common/src/com/netscape/certsrv/dbs/EDBException.java
index 1908bdf7e..279b9fb70 100644
--- a/base/common/src/com/netscape/certsrv/dbs/EDBException.java
+++ b/base/common/src/com/netscape/certsrv/dbs/EDBException.java
@@ -51,17 +51,6 @@ public class EDBException extends EBaseException {
      * <P>
      *
      * @param msgFormat message format
-     * @param param parameter
-     */
-    public EDBException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a database exception.
-     * <P>
-     *
-     * @param msgFormat message format
      * @param e exception as parameter
      */
     public EDBException(String msgFormat, Exception e) {
diff --git a/base/common/src/com/netscape/certsrv/extensions/EExtensionsException.java b/base/common/src/com/netscape/certsrv/extensions/EExtensionsException.java
index 5374a466a..e3ce3366e 100644
--- a/base/common/src/com/netscape/certsrv/extensions/EExtensionsException.java
+++ b/base/common/src/com/netscape/certsrv/extensions/EExtensionsException.java
@@ -40,10 +40,6 @@ public class EExtensionsException extends EBaseException {
         super(msgFormat);
     }
 
-    public EExtensionsException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
     public EExtensionsException(String msgFormat, Exception e) {
         super(msgFormat, e);
     }
diff --git a/base/common/src/com/netscape/certsrv/jobs/EJobsException.java b/base/common/src/com/netscape/certsrv/jobs/EJobsException.java
index 38b9db6b9..8632d6ca3 100644
--- a/base/common/src/com/netscape/certsrv/jobs/EJobsException.java
+++ b/base/common/src/com/netscape/certsrv/jobs/EJobsException.java
@@ -48,14 +48,6 @@ public class EJobsException extends EBaseException {
      * Constructs a Identity exception.
      * <P>
      */
-    public EJobsException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a Identity exception.
-     * <P>
-     */
     public EJobsException(String msgFormat, Exception e) {
         super(msgFormat, e);
     }
diff --git a/base/common/src/com/netscape/certsrv/kra/EKRAException.java b/base/common/src/com/netscape/certsrv/kra/EKRAException.java
index a42e8f409..c2b802078 100644
--- a/base/common/src/com/netscape/certsrv/kra/EKRAException.java
+++ b/base/common/src/com/netscape/certsrv/kra/EKRAException.java
@@ -54,17 +54,6 @@ public class EKRAException extends EBaseException {
      * <P>
      *
      * @param msgFormat constant from KRAResources.
-     * @param param additional parameters to the message.
-     */
-    public EKRAException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a KRA exception.
-     * <P>
-     *
-     * @param msgFormat constant from KRAResources.
      * @param e embedded exception.
      */
     public EKRAException(String msgFormat, Exception e) {
diff --git a/base/common/src/com/netscape/certsrv/ldap/ELdapException.java b/base/common/src/com/netscape/certsrv/ldap/ELdapException.java
index 57d7ca958..2f4943c6d 100644
--- a/base/common/src/com/netscape/certsrv/ldap/ELdapException.java
+++ b/base/common/src/com/netscape/certsrv/ldap/ELdapException.java
@@ -51,18 +51,6 @@ public class ELdapException extends EBaseException {
      * Constructs a Ldap exception.
      *
      * @param msgFormat Resource Key, if key not present, serves as the message.
-     *            Include a message string parameter for variable content.
-     * @param param Message string parameter.
-     *            <P>
-     */
-    public ELdapException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a Ldap exception.
-     *
-     * @param msgFormat Resource Key, if key not present, serves as the message.
      * @param e Common exception.
      *            <P>
      */
diff --git a/base/common/src/com/netscape/certsrv/listeners/EListenersException.java b/base/common/src/com/netscape/certsrv/listeners/EListenersException.java
index 1169de0b1..e1db15209 100644
--- a/base/common/src/com/netscape/certsrv/listeners/EListenersException.java
+++ b/base/common/src/com/netscape/certsrv/listeners/EListenersException.java
@@ -47,17 +47,6 @@ public class EListenersException extends EBaseException {
     }
 
     /**
-     * Constructs a listeners exception.
-     * <P>
-     *
-     * @param msgFormat exception details in message string format.
-     * @param param message string parameter.
-     */
-    public EListenersException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
      * Constructs a Listeners exception.
      * <P>
      *
diff --git a/base/common/src/com/netscape/certsrv/notification/ENotificationException.java b/base/common/src/com/netscape/certsrv/notification/ENotificationException.java
index 096d6e3a5..13371d9b7 100644
--- a/base/common/src/com/netscape/certsrv/notification/ENotificationException.java
+++ b/base/common/src/com/netscape/certsrv/notification/ENotificationException.java
@@ -48,14 +48,6 @@ public class ENotificationException extends EBaseException {
      * Constructs a Identity exception.
      * <P>
      */
-    public ENotificationException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a Identity exception.
-     * <P>
-     */
     public ENotificationException(String msgFormat, Exception e) {
         super(msgFormat, e);
     }
diff --git a/base/common/src/com/netscape/certsrv/password/EPasswordCheckException.java b/base/common/src/com/netscape/certsrv/password/EPasswordCheckException.java
index 6b2459759..7ed8d9060 100644
--- a/base/common/src/com/netscape/certsrv/password/EPasswordCheckException.java
+++ b/base/common/src/com/netscape/certsrv/password/EPasswordCheckException.java
@@ -52,17 +52,6 @@ public class EPasswordCheckException extends EBaseException {
      * <P>
      *
      * @param msgFormat exception details in message string format
-     * @param param message string parameter
-     */
-    public EPasswordCheckException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a password checker exception.
-     * <P>
-     *
-     * @param msgFormat exception details in message string format
      * @param exception system exception
      */
     public EPasswordCheckException(String msgFormat, Exception exception) {
diff --git a/base/common/src/com/netscape/certsrv/usrgrp/EUsrGrpException.java b/base/common/src/com/netscape/certsrv/usrgrp/EUsrGrpException.java
index cce9f3f3d..dff02cb41 100644
--- a/base/common/src/com/netscape/certsrv/usrgrp/EUsrGrpException.java
+++ b/base/common/src/com/netscape/certsrv/usrgrp/EUsrGrpException.java
@@ -49,17 +49,6 @@ public class EUsrGrpException extends EBaseException {
     /**
      * Constructs a Identity exception.
      *
-     * @param msgFormat exception details in message string format
-     * @param param message string parameter
-     *            <P>
-     */
-    public EUsrGrpException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a Identity exception.
-     *
      * @param e system exception
      *            <P>
      */
diff --git a/base/ocsp/src/com/netscape/ocsp/EOCSPException.java b/base/ocsp/src/com/netscape/ocsp/EOCSPException.java
index 1c878ad75..30574891f 100644
--- a/base/ocsp/src/com/netscape/ocsp/EOCSPException.java
+++ b/base/ocsp/src/com/netscape/ocsp/EOCSPException.java
@@ -48,14 +48,6 @@ public class EOCSPException extends EBaseException {
      * Constructs a OCSP exception.
      * <P>
      */
-    public EOCSPException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a OCSP exception.
-     * <P>
-     */
     public EOCSPException(String msgFormat, Exception e) {
         super(msgFormat, e);
     }
diff --git a/base/server/cms/src/com/netscape/cms/authentication/DNPattern.java b/base/server/cms/src/com/netscape/cms/authentication/DNPattern.java
index ccee3b512..c62af4afc 100644
--- a/base/server/cms/src/com/netscape/cms/authentication/DNPattern.java
+++ b/base/server/cms/src/com/netscape/cms/authentication/DNPattern.java
@@ -163,7 +163,7 @@ public class DNPattern {
             try {
                 lastChar = in.read();
             } catch (IOException e) {
-                throw new EAuthException("CMS_AUTHENTICATION_INTERNAL_ERROR", e.toString());
+                throw new EAuthException("CMS_AUTHENTICATION_INTERNAL_ERROR", e);
             }
         } while (lastChar == ',');
 
diff --git a/base/server/cms/src/com/netscape/cms/servlet/common/ECMSGWException.java b/base/server/cms/src/com/netscape/cms/servlet/common/ECMSGWException.java
index 2c24c112a..68a05c4f3 100644
--- a/base/server/cms/src/com/netscape/cms/servlet/common/ECMSGWException.java
+++ b/base/server/cms/src/com/netscape/cms/servlet/common/ECMSGWException.java
@@ -48,14 +48,6 @@ public class ECMSGWException extends EBaseException {
      * Constructs a CMSGW exception.
      * <P>
      */
-    public ECMSGWException(String msgFormat, String param) {
-        super(msgFormat, param);
-    }
-
-    /**
-     * Constructs a CMSGW exception.
-     * <P>
-     */
     public ECMSGWException(String msgFormat, Exception e) {
         super(msgFormat, e);
     }