diff options
| author | Martin Kosek <mkosek@redhat.com> | 2011-01-14 10:24:04 +0100 |
|---|---|---|
| committer | Simo Sorce <ssorce@redhat.com> | 2011-01-14 14:20:57 -0500 |
| commit | c94d20cfd8cc1bd8cd8152b19d6807b654286197 (patch) | |
| tree | 963fb678ee96ef9403e1fa54d0d1d94bc4976193 /daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c | |
| parent | a6a91e5dbc96498ef33505e4bf96466590f0da42 (diff) | |
| download | freeipa-c94d20cfd8cc1bd8cd8152b19d6807b654286197.tar.gz freeipa-c94d20cfd8cc1bd8cd8152b19d6807b654286197.tar.xz freeipa-c94d20cfd8cc1bd8cd8152b19d6807b654286197.zip | |
Unchecked return values in SLAPI plugins
Return values weren't checked in several cases which could
have lead to unhandled errors.
https://fedorahosted.org/freeipa/ticket/722
Diffstat (limited to 'daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c')
| -rw-r--r-- | daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c index 6049c040..45a29a51 100644 --- a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c +++ b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c @@ -748,8 +748,8 @@ static int ipamodrdn_post_op(Slapi_PBlock *pb) Slapi_Value *val; const char *strval; - slapi_attr_first_value(sattr, &val); - if (!val) { + ret = slapi_attr_first_value(sattr, &val); + if (ret == -1 || !val) { LOG_FATAL("Source attr %s is empty\n", cfgentry->sattr); continue; } |