From c94d20cfd8cc1bd8cd8152b19d6807b654286197 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Fri, 14 Jan 2011 10:24:04 +0100 Subject: Unchecked return values in SLAPI plugins Return values weren't checked in several cases which could have lead to unhandled errors. https://fedorahosted.org/freeipa/ticket/722 --- daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c') diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c index 6049c040..45a29a51 100644 --- a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c +++ b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c @@ -748,8 +748,8 @@ static int ipamodrdn_post_op(Slapi_PBlock *pb) Slapi_Value *val; const char *strval; - slapi_attr_first_value(sattr, &val); - if (!val) { + ret = slapi_attr_first_value(sattr, &val); + if (ret == -1 || !val) { LOG_FATAL("Source attr %s is empty\n", cfgentry->sattr); continue; } -- cgit