diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-08 10:52:25 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:40:32 -0700 |
| commit | 603c5fcc52201d9eca690c5bef29e4e39e340f56 (patch) | |
| tree | bd559bf1eda43f29a124599e33cb3eddc6888f5e /lib | |
| parent | 2d69093cf71107b36a58b7d7359abc9ca93071f1 (diff) | |
| download | ds-603c5fcc52201d9eca690c5bef29e4e39e340f56.tar.gz ds-603c5fcc52201d9eca690c5bef29e4e39e340f56.tar.xz ds-603c5fcc52201d9eca690c5bef29e4e39e340f56.zip | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11831 DEADCODE Triaged Unassigned Bug Minor Fix Required
config_set_value() ds/ldap/servers/slapd/libglobs.c
Comment:
The config_set_value meant to set various values (e.g. "off"
and "unknown") depending upon the config_var_type, but this
code overrides the spec and set the empty string to all cases.
- /* for null values, just set the attr value to the empty
- string */
- if (!value) {
- slapi_entry_attr_set_charptr(e, cgas->attr_name, "");
- return;
- }
This patch removes the above blind empty string setting and
relies on the values in each config_var_type case. Plus, adding
the NULL value check to CONFIG_CHARRAY.
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions