diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-02 15:13:19 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:25:28 -0700 |
| commit | 2c2b3ecea9f478bc0e7308ace741ee9e2429acb7 (patch) | |
| tree | d16907e289632694ac30ff4ee589244ab6019a44 /lib | |
| parent | 7a5db43cc8dd899b62416a683c701416dd5d96e7 (diff) | |
| download | ds-2c2b3ecea9f478bc0e7308ace741ee9e2429acb7.tar.gz ds-2c2b3ecea9f478bc0e7308ace741ee9e2429acb7.tar.xz ds-2c2b3ecea9f478bc0e7308ace741ee9e2429acb7.zip | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11806 DEADCODE Triaged Unassigned Bug Moderate Fix Required
agmt_set_last_init_status() ds/ldap/servers/plugins/replication/repl5_agmt.c
Comment:
macro NSDS50_REPL_REPLICA_READY is 0
repl5.h:#define NSDS50_REPL_REPLICA_READY 0x00 /* Replica ready, go ahead */
Because of this if expression:
1991 else if (replrc != 0)
"Replica acquired successfully" never be set to last_init_status.
Removed (replrc == NSDS50_REPL_REPLICA_READY) checking from the
else if (replrc != 0) clause and added "Replica acquired successfully"
to the string to print message since replrc == NSDS50_REPL_REPLICA_READY
there.
11807 DEADCODE Triaged Unassigned Bug Moderate Fix Required
agmt_set_last_update_status() ds/ldap/servers/plugins/replication/repl5_agmt.c
Comment:
macro NSDS50_REPL_REPLICA_READY is 0
repl5.h:#define NSDS50_REPL_REPLICA_READY 0x00 /* Replica ready, go ahead */
Because of this if expression:
1991 else if (replrc != 0)
"Replica acquired successfully" never be set to last_update_status.
Removed (replrc == NSDS50_REPL_REPLICA_READY) checking from the
else if (replrc != 0) clause and added "Replica acquired successfully"
to the string to print message since replrc == NSDS50_REPL_REPLICA_READY
there.
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions