diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2010-07-26 14:05:34 -0500 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-19 17:01:25 -0700 |
| commit | e23c8bd9994d5592738cb44e1c2b426aba7fbd4a (patch) | |
| tree | fd02213432928a283eca79842fb7e1bb2b54e302 | |
| parent | 458ef0f1c26ef61590d70d696d3ba219aa86c106 (diff) | |
| download | ds-e23c8bd9994d5592738cb44e1c2b426aba7fbd4a.tar.gz ds-e23c8bd9994d5592738cb44e1c2b426aba7fbd4a.tar.xz ds-e23c8bd9994d5592738cb44e1c2b426aba7fbd4a.zip | |
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
https://bugzilla.redhat.com/show_bug.cgi?id=617630
Resolves: bug 617630
Bug description: fix coverify Defect Type: Resource leaks issues CID 12090.
description: The entry_add_present_values_wsi() has been modified to release valuestoadd before returning.
| -rw-r--r-- | ldap/servers/slapd/entrywsi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ldap/servers/slapd/entrywsi.c b/ldap/servers/slapd/entrywsi.c index 01c160c2..4892732d 100644 --- a/ldap/servers/slapd/entrywsi.c +++ b/ldap/servers/slapd/entrywsi.c @@ -475,7 +475,6 @@ entry_add_present_values_wsi(Slapi_Entry *e, const char *type, struct berval **b /* Append the pending values to a->a_present_values */ valuearray_update_csn (valuestoadd,CSN_TYPE_VALUE_UPDATED,csn); valueset_add_valuearray_ext(&a->a_present_values, valuestoadd, SLAPI_VALUE_FLAG_PASSIN); - slapi_ch_free ( (void **)&valuestoadd ); /* * Now delete non-RDN values from a->a_present_values; and @@ -522,10 +521,11 @@ entry_add_present_values_wsi(Slapi_Entry *e, const char *type, struct berval **b } valuearray_update_csn(valuestoadd,CSN_TYPE_VALUE_UPDATED,csn); retVal= attr_add_valuearray(a, valuestoadd, slapi_entry_get_dn_const(e)); - valuearray_free(&valuestoadd); } a->a_flags = a_flags_orig; } + + valuearray_free(&valuestoadd); return(retVal); } |