diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-02 16:35:16 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:35:05 -0700 |
| commit | c38c2a860937cda0cdbe8f05acaa8083feb8caf1 (patch) | |
| tree | 07a6d71fbe6ec68bd83fd57b35bf18bc7297b89b | |
| parent | e5da45f9754a824c89d4b9e2598f9e9eee8c7823 (diff) | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11813 DEADCODE Triaged Unassigned Bug Minor Fix Required
send_dirsync_search() ds/ldap/servers/plugins/replication/windows_connection.c
Comment:
op_string points to a static string:
731 op_string = "search";
We don't need to check op_string in slapi_log_error.
| -rw-r--r-- | ldap/servers/plugins/replication/windows_connection.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/replication/windows_connection.c b/ldap/servers/plugins/replication/windows_connection.c index 2e24bfed..7adf3be3 100644 --- a/ldap/servers/plugins/replication/windows_connection.c +++ b/ldap/servers/plugins/replication/windows_connection.c @@ -758,7 +758,7 @@ send_dirsync_search(Repl_Connection *conn) slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name, "%s: Failed to get %s operation: LDAP error %d (%s)\n", agmt_get_long_name(conn->agmt), - op_string ? op_string : "NULL", rc, ldap_err2string(rc)); + op_string, rc, ldap_err2string(rc)); conn->last_ldap_error = rc; if (IS_DISCONNECT_ERROR(rc)) { |