diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-02 10:31:17 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:18:37 -0700 |
| commit | 782432e0ea5e795dd4fa7eb0b3c04df28d8fa072 (patch) | |
| tree | 32270883fc0d241f0f67b38c53b6a27db76431c8 | |
| parent | 92d7458355c775ddd62bb82c58cffe2472ee5ff9 (diff) | |
| download | ds-782432e0ea5e795dd4fa7eb0b3c04df28d8fa072.tar.gz ds-782432e0ea5e795dd4fa7eb0b3c04df28d8fa072.tar.xz ds-782432e0ea5e795dd4fa7eb0b3c04df28d8fa072.zip | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11795 DEADCODE Triaged Unassigned Bug Minor Fix Required
DS_LASRoleDnAttrEval() ds/ldap/servers/plugins/acl/acllas.c
Comment:
Merged the 2 lines to check matched with ACL_TRUE into one.
| -rw-r--r-- | ldap/servers/plugins/acl/acllas.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/ldap/servers/plugins/acl/acllas.c b/ldap/servers/plugins/acl/acllas.c index 12cefaf4..5de18661 100644 --- a/ldap/servers/plugins/acl/acllas.c +++ b/ldap/servers/plugins/acl/acllas.c @@ -3920,16 +3920,10 @@ DS_LASRoleDnAttrEval(NSErr_t *errp, char *attr_name, CmpOp_t comparator, ** Let's compare with the client, thi might be just an user. If it is not ** then we test it against the list of groups. */ - if ((matched = acllas__user_has_role( - lasinfo.aclpb, - roleDN, - lasinfo.aclpb->aclpb_authorization_sdn)) == ACL_TRUE){ - slapi_ch_free ( (void **)&n_attrval ); - slapi_sdn_free(&roleDN ); - break; - } + matched = acllas__user_has_role(lasinfo.aclpb, + roleDN, lasinfo.aclpb->aclpb_authorization_sdn); slapi_ch_free ( (void **)&n_attrval ); - slapi_sdn_free(&roleDN ); + slapi_sdn_free(&roleDN); if (matched == ACL_TRUE) { break; } else if ( matched == ACL_DONT_KNOW ) { |