summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNathan Kinder <nkinder@redhat.com>2010-09-15 11:45:56 -0700
committerNathan Kinder <nkinder@redhat.com>2010-09-15 11:45:56 -0700
commit470e2c70338440f69b0ab8fc02128fe5f204af3e (patch)
treea5606dd7847e0c96567160dc8c10cfa4532da6e2
parent529b056b2fda91263730da1da8ac9b42b54b72f4 (diff)
downloadds-470e2c70338440f69b0ab8fc02128fe5f204af3e.tar.gz
ds-470e2c70338440f69b0ab8fc02128fe5f204af3e.tar.xz
ds-470e2c70338440f69b0ab8fc02128fe5f204af3e.zip
Bug 630097 - (cov#11938) NULL dereference in mmldif
There is a chance that a can be NULL, which we then dereference within the else block. We should not execute the else block if a is NULL.
-rw-r--r--ldap/servers/slapd/tools/mmldif.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/slapd/tools/mmldif.c b/ldap/servers/slapd/tools/mmldif.c
index 665452cb..b364a19c 100644
--- a/ldap/servers/slapd/tools/mmldif.c
+++ b/ldap/servers/slapd/tools/mmldif.c
@@ -1108,7 +1108,7 @@ addmodified(FILE * edf3, attrib1_t * attrib, record_t * first)
} while (num_b <= tot_b && stricmp(attribname(b), attrname) == 0);
fprintf(edf3, "-\n");
continue;
- } else {
+ } else if (a != NULL) {
/* a == b */
int nmods = 0;
attrib_t *begin_b = b;