summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRich Megginson <rmeggins@redhat.com>2010-08-18 14:51:15 -0600
committerRich Megginson <rmeggins@redhat.com>2010-08-18 14:51:15 -0600
commit2a40b4d91c3f154b462b867093af2224dde02428 (patch)
tree06860861dbcd94234cd7dc07c1c939a88e24deca
parent9174cc61589ef4fc554ca82077bbddabc06e617b (diff)
Bug 610281 - fix coverity Defect Type: Control flow issues - last repl init status
https://bugzilla.redhat.com/show_bug.cgi?id=610281 Resolves: bug 610281 Bug Description: fix coverity Defect Type: Control flow issues - last repl init status Reviewed by: one-line rule Branch: master Fix Description: agmt_set_last_init_status() is never called in order to set the status to "Replica acquired successfully". Adding that string to the message breaks tests that expect init success to report 0 Total update succeeded Platforms tested: RHEL5 x86_64, Fedora 14 x86_64 Flag Day: no Doc impact: no
-rw-r--r--ldap/servers/plugins/replication/repl5_agmt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/replication/repl5_agmt.c b/ldap/servers/plugins/replication/repl5_agmt.c
index b5fcf957..3a052138 100644
--- a/ldap/servers/plugins/replication/repl5_agmt.c
+++ b/ldap/servers/plugins/replication/repl5_agmt.c
@@ -2030,7 +2030,7 @@ agmt_set_last_init_status (Repl_Agmt *ra, int ldaprc, int replrc, const char *me
else if (message != NULL) /* replrc == NSDS50_REPL_REPLICA_READY == 0 */
{
PR_snprintf(ra->last_init_status, STATUS_LEN,
- "%d Replica acquired successfully: %s",
+ "%d %s",
ldaprc, message);
}
else