More testing and fixes.

git-svn-id: svn://svn.autonomy.net.au/python-dmidecode@127 abc39116-655e-4be6-ad55-d661dc543056

1 files changed, 7 insertions, 3 deletions

diff --git a/src/dmidecodemodule.c b/src/dmidecodemodule.c
index 3214308..e873c6c 100644
--- a/src/dmidecodemodule.c
+++ b/src/dmidecodemodule.c
@@ -157,9 +157,13 @@ static PyObject* dmidecode_get_type(PyObject *self, PyObject *args)      {
   return Py_None;
 }
 
-static PyObject* dmidecode_dump(PyObject *self, PyObject *args) {
-  const char *f =  PyString_AsString(opt.dumpfile);
-  if((access(f, F_OK) != 0) || (access(f, W_OK) == 0))
+static PyObject* dmidecode_dump(PyObject *self, PyObject *null) {
+  const char *f;
+  f = opt.dumpfile ? PyString_AsString(opt.dumpfile) : opt.devmem;
+  struct stat buf;
+  stat(f, &buf);
+
+  if((access(f, F_OK) != 0) || ((access(f, W_OK) == 0) && S_ISREG(buf.st_mode)))
     if(dump(PyString_AS_STRING(opt.dumpfile)))
       Py_RETURN_TRUE;
   Py_RETURN_FALSE;