summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Sommerseth <davids@redhat.com>2013-06-20 12:58:12 +0200
committerDavid Sommerseth <davids@redhat.com>2013-06-20 12:58:12 +0200
commit69a1c9ca658c9708698cde6aee32af7bb2e16f9a (patch)
tree20a8b698aac3fbcfe9379d68cc438cdceff1d089
parentb82aff22223e8c47857b8eb09bf21f1b15887fc4 (diff)
downloadpython-dmidecode-69a1c9ca658c9708698cde6aee32af7bb2e16f9a.tar.gz
python-dmidecode-69a1c9ca658c9708698cde6aee32af7bb2e16f9a.tar.xz
python-dmidecode-69a1c9ca658c9708698cde6aee32af7bb2e16f9a.zip
Fixed a missing break statement in a switch for DMI section 3.3.7.2
This missing break could cause duplicated 'installed' attributes in <InstalledSize/> or <EnabledSize/> XML tags. This is only happening when dmi_memory_module_size() is called and only on some hardware. Signed-off-by: David Sommerseth <davids@redhat.com>
-rw-r--r--src/dmidecode.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/dmidecode.c b/src/dmidecode.c
index 215c3f4..dae2fef 100644
--- a/src/dmidecode.c
+++ b/src/dmidecode.c
@@ -1516,6 +1516,7 @@ void dmi_memory_module_size(xmlNode *node, const char *tagname, u8 code)
case 0x7F:
dmixml_AddAttribute(data_n, "installed", "0");
check_conn = 0;
+ break;
default:
dmixml_AddAttribute(data_n, "installed", "1");
dmixml_AddAttribute(data_n, "unit", "MB");