summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Update version.m4 - we're past 2.3_alpha2 nowDavid Sommerseth2012-07-021-1/+1
| | | | Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
* Repair "tap server" mode brokenness caused by <stdbool.h> falloutGert Doering2012-07-021-1/+1
| | | | | | | | | | | | | | | Operator/Cast precedence wrong: casting mac[0] to (bool) first - giving "1" for "any mac address that does not start with 00:" - and only then bit-anding with "1" - thus always returning "true". Which, in turn, leads to "reject all incoming packets with 'bad source address'". OpenVPN bug #216. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: Fabian Knittel <fabian.knittel@lettink.de> Message-Id: 1341089443-2287-1-git-send-email-gert@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6817 Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
* Set the correct version number - 2.3_alpha2v2.3_alpha2David Sommerseth2012-06-291-1/+1
| | | | Signed-off-by: David Sommerseth <davids@redhat.com>
* Prepare the OpenVPN v2.3_alpha2 releaseDavid Sommerseth2012-06-292-2/+158
| | | | Signed-off-by: David Sommerseth <davids@redhat.com>
* build: msvc: chdir with change drive to script locationAlon Bar-Lev2012-06-293-3/+2
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: Samuli Seppänen <samuli@openvpn.net> Message-Id: 1335639118-16671-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6383 Signed-off-by: David Sommerseth <davids@redhat.com>
* cleanup: windows: convert argv (UCS-2 to UTF-8) at earliestAlon Bar-Lev2012-06-294-33/+47
| | | | | | | | | | | | | | | | Discussed at [1]. Use wmain under windows, drop the custom parsing and shell32 linkage. There is no need for gc magic as this allocation is static. [1] http://permalink.gmane.org/gmane.network.openvpn.devel/5433 Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Message-Id: 1332621070-28464-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6063 Tested-by: Samuli Seppänen <samuli@openvpn.net> Signed-off-by: David Sommerseth <davids@redhat.com>
* build: plugins: set defaults based on platformAlon Bar-Lev2012-06-271-4/+15
| | | | | | | | | | | | pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Acked-by: Samuli Seppänen <samuli@openvpn.net> Message-Id: 1340719406-12157-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6795 Signed-off-by: David Sommerseth <davids@redhat.com>
* Added notes about upgrading from 2.3-alpha1 and earlier to INSTALL-win32.txtSamuli Seppänen2012-06-271-0/+25
| | | | | | | | Signed-off-by: Samuli Seppänen <samuli@openvpn.net> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1340703181-9185-1-git-send-email-samuli@openvpn.net URL: http://article.gmane.org/gmane.network.openvpn.devel/6779 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: integrate plugins build into core buildAlon Bar-Lev2012-06-2633-112/+201
| | | | | | | | | | | | | | | | | | As disucssed[1], keep plugins in repository. 1, Proper automake/libtool build. 2. Move example plugins to samples/sample-plugins. 3. Plugins are installed at LIBDIR/openvpn/plugins. [1] http://comments.gmane.org/gmane.network.openvpn.devel/6436 Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1337035323-27465-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6591 Signed-off-by: David Sommerseth <davids@redhat.com>
* Remove ENABLE_CONNECTIONS ifdefsArne Schwabe2012-06-226-84/+1
| | | | | | | | | | | Connections were always on for a long time. Note that ENABLE_MAMAGEMENT_REMOTE was only depending on ENABLE_CONNECTIONS and is removed as well Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: James Yonan <james@openvpn.net> Message-Id: 1340044749-10694-5-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6744 Signed-off-by: David Sommerseth <davids@redhat.com>
* Remove ENABLE_INLINE_FILES conditionalsArne Schwabe2012-06-2210-142/+23
| | | | | | | | | | This code is always enabled and removing the #ifdef make the code a little bit clearer Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: James Yonan <james@openvpn.net> Message-Id: 1340044749-10694-4-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6746 Signed-off-by: David Sommerseth <davids@redhat.com>
* Completely remove ancient IANA port warning.Arne Schwabe2012-06-223-10/+0
| | | | | | | | Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1340044749-10694-3-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6742 Signed-off-by: David Sommerseth <davids@redhat.com>
* Only use tmpdir if tmp_dir is really used.Arne Schwabe2012-06-222-3/+8
| | | | | | | | | | | | This fixes starting openvpn compiled as client only version of systems that have no /tmp (Android). --tmp-dir could only be set if P2MP_SERVER has been enabled too. Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1340044749-10694-2-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6741 Signed-off-by: David Sommerseth <davids@redhat.com>
* cleanup: pkcs11.c: resolve waningsAlon Bar-Lev2012-06-221-1/+1
| | | | | | | | | | | src/openvpn/pkcs11.c:794:2: warning: passing argument 1 of ‘pkcs11h_setPINPromptHook’ from incompatible pointer type Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1340040904-23950-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6738 Signed-off-by: David Sommerseth <davids@redhat.com>
* Remove #include "config.h" from ssl_polarssl.hGert Doering2012-06-151-1/+0
| | | | | | | | | | | This include is superfluous, as all callers already include config.h - and under certain combinations of configure options and syshead.h Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: Alon Bar-Lev <alon.barlev@gmail.com> Message-Id: 20120614144454.GX1059@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6723 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: add --with-special-build to provide special build stringAlon Bar-Lev2012-06-132-0/+9
| | | | | | | | | | | | | | Special build string is printed when --version is specified. Empty = no special build. This is handy when building a snapshot or if not git repository. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1336204877-3564-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6435 Signed-off-by: David Sommerseth <davids@redhat.com>
* Update TODO.IPv6 listGert Doering2012-06-131-7/+28
| | | | | | | | | | Clarify status of each already-done item for "IPv6 payload" TODOs. Remove TODOs from "IPv6 transport" list that have been solved in "IPv6 payload" work. Signed-off-by: Gert Doering <gert@greenie.muc.de> Signed-off-by: David Sommerseth <davids@redhat.com>
* Add missing pieces to IPv6 route gateway handling.Gert Doering2012-06-132-14/+64
| | | | | | | | | | | | | | | | | | | | | OpenVPN on Linux (iproute2+ifconfig), FreeBSD and MacOS X (Darwin) normally points routes directly towards the "tun" interface, obviating the need for a gateway. For "tap" interfaces, now add gateway spec to linux route command, and replace "-iface <dev>" with gateway spec (both together do not work) on FreeBSD and MacOS X. Also adapt "route delete" appropriately, otherwise route will not be found. All other platforms already use the gateway address for tun and tap, because there's no way to install a route "towards an interface" there. Remove warning about missing IPv6 route gateway handling. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1339342891-28443-5-git-send-email-gert@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6712 Signed-off-by: David Sommerseth <davids@redhat.com>
* Remove warning about "explicit support for IPv6 tun devices is not provided ↵Gert Doering2012-06-131-1/+1
| | | | | | | | | | for this OS" for MacOS X (because it *is*). Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1339342891-28443-4-git-send-email-gert@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6716 Signed-off-by: David Sommerseth <davids@redhat.com>
* remove "*option" element in "struct route_ipv6"Gert Doering2012-06-131-1/+0
| | | | | | | | | | | this used to point to the "route_ipv6_option" that created this specific route entry, but nobody ever queried this field -> dead code. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1339342891-28443-3-git-send-email-gert@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6714 Signed-off-by: David Sommerseth <davids@redhat.com>
* cleanup and redefine metric handling for IPv6 routesGert Doering2012-06-133-6/+9
| | | | | | | | | | | | "no metric set" is now stored as "-1" "metric 0" means "on-link route" (what the BSDs do) properly initialize metric value to "0" for on-link IPv6 net on BSDs Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1339342891-28443-2-git-send-email-gert@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6710 Signed-off-by: David Sommerseth <davids@redhat.com>
* Fix reported compile issues on OSX 10.6.8Frank de Brabander2012-06-131-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not the a problem when building using the latest Mac OS X SDK. I've did a quick search and it seems to be a more common issue on some (old) Darwin platforms. [ Additional review note from Gert Doering: IPV6_PKTINFO is part of the "extended socket API" defined in RFC2292. That RFC used IPV6_PKTINFO both for receiving the destination IPv6 address in UDP packets, and for setting the source address for outgoing packets. RFC2292 was updated by RFC3542, which renamed the "receive" function to IPV6_RECVPKTINFO, leaving the "sending" function as IPV6_PKTINFO - and, subsequently, in FreeBSD they have different "setsockopt()" opcodes. So, on a system that has *both*, we need to use IPV6_RECVPKTINFO for receving (turning it on with setsockopt) to make --multihome work, and IPV6_PKTINFO for sending (which we don't actually do). On a system that only has IPV6_PKTINFO, because it's API only implements 2292 (MacOS up until 10.6), use IPV6_PKTINFO for setsockopt(). Now, the interesting question is whether a 10.5-compiled openvpn.exe will behave correctly under 10.7 if --multihome is active... ] Signed-off-by: Frank de Brabander <debrabander@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: eb2837a3-ce55-4f52-b2fe-f822efc661f7@l14g2000vbe.googlegroups.com URL: http://article.gmane.org/gmane.network.openvpn.devel/5591 Signed-off-by: David Sommerseth <davids@redhat.com>
* Implement search for "first free" tun/tap device on SolarisGert Doering2012-06-131-8/+32
| | | | | | | | | | | | | Without this patch, Solaris will do "--dev tun3" just fine, but "--dev tun" will either use "tun0" if that is available, or fail. With the patch, the first available device is searched if "--dev tun" or "--dev tap" (without a number) is specified. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 20120607174638.GW1059@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6705 Signed-off-by: David Sommerseth <davids@redhat.com>
* t_client.sh - fix for iproute2, print summary lineGert Doering2012-06-131-1/+11
| | | | | | | | | | | | | Yet another postprocess-output fix for iproute2 (sometimes there was no whitespace in the output, so substituting away expiry time failed). Print summary line of succeeded and failed test sets at the very end. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 20120607174255.GV1059@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6704 Signed-off-by: David Sommerseth <davids@redhat.com>
* remove the --auto-proxy option from openvpnHeiko Hund2012-06-138-342/+11
| | | | | | | | | | | | | | During discussion on FOSDEM 2012 it was decided that proxy auto detection is best done in the GUI as it's highly platform specific and shouldn't be handled in openvpn itself for every supported platform in openvpn itself. This removes --auto-proxy from openvpn. Signed-off-by: Heiko Hund <heiko.hund@sophos.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1328446029-30523-1-git-send-email-heiko.hund@sophos.com URL: http://article.gmane.org/gmane.network.openvpn.devel/5333 Signed-off-by: David Sommerseth <davids@redhat.com>
* Add the name of the context where option is not allowed to the error message.Arne Schwabe2012-06-071-2/+3
| | | | | | | | | | | | | | | | | Changes Options error: option 'dhcp-option' cannot be used in this context to P:Options error: option 'dhcp-option' cannot be used in this context ([PUSH-OPTIONS]) Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1338642223-20324-6-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6646 Signed-off-by: David Sommerseth <davids@redhat.com>
* Explain that route-nopull also causes the client to ignore dhcp options.Arne Schwabe2012-06-072-2/+3
| | | | | | | | Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1338642223-20324-5-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6649 Signed-off-by: David Sommerseth <davids@redhat.com>
* Add the query to the error message. Makes the diagnose what went wrong from ↵Arne Schwabe2012-06-071-1/+1
| | | | | | | | | | logs easier. Signed-off-by: Arne Schwabe <arne@rfc2549.org> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1338642223-20324-3-git-send-email-arne@rfc2549.org URL: http://article.gmane.org/gmane.network.openvpn.devel/6645 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: do not support <polarssl-1.1.0Alon Bar-Lev2012-06-071-1/+1
| | | | | | | | | | Reported-by: Samuli Seppänen <samuli@openvpn.net> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: Samuli Seppänen <samuli@openvpn.net> Acked-by: Adriaan de Jong <dejong@fox-it.com> Message-Id: 1339061824-16542-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6686 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: support platforms that does not need explicit tun headersAlon Bar-Lev2012-06-041-0/+2
| | | | | | | | | | | | | Both "generic" and Darwin have no special headers to use tap. Fixes commit 7cacdfd4b7. Reported-by: Arne Schwabe <arne@rfc2549.org> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1338651109-15806-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6659 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: update INSTALL to recent changesAlon Bar-Lev2012-06-041-62/+88
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1338785107-592-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6676 Signed-off-by: David Sommerseth <davids@redhat.com>
* Remove two unused functionsDavid Sommerseth2012-06-012-19/+0
| | | | | | | | | | Both is_persist_option() and is_stateful_restart() functions where never used anywhere in the code. Remove them. Signed-off-by: David Sommerseth <davids@redhat.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1336036240-23838-1-git-send-email-dazo@users.sourceforge.net URL: http://article.gmane.org/gmane.network.openvpn.devel/6402
* build: cleanup: yet another forgotten bracketsAlon Bar-Lev2012-06-011-1/+1
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1336200540-10327-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6434 Signed-off-by: David Sommerseth <davids@redhat.com>
* t_client.sh iproute2 script fixesGert Doering2012-06-011-2/+2
| | | | | | | | | | | | | | Test for existance of "iproute2" with "-n" (Alon) Work around "ip -6 route show" behaviour on FC14 where some parts of the IPv6 route cache would be displayed, which has no relevance to OpenVPN but breaks before/after comparison. Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 20120601151507.GE400@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6637 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: add git revision to --version output if build from git repositoryAlon Bar-Lev2012-06-016-0/+46
| | | | | | | | | | | If source is located at git repository, acquire branch and revision of head to be printed at --version output. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1336199983-9916-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6431 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: detect sys/wait.h required for *bsdAlon Bar-Lev2012-06-011-1/+1
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: 1336813338-9219-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6532 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: insall README* document using build systemAlon Bar-Lev2012-06-012-4/+10
| | | | | | | | | | | | | | | | | | Purpose: make distro packager task simpler, more flexible to provide more documentation without changing the packaging script. Remove installation related documents from rpm as package already installed when viewed. +Workaround rpm bug[1]. [1] http://rpm.org/ticket/836 Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1336849433-23066-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6536 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: spec: we support openssl >= 0.9.7Alon Bar-Lev2012-06-011-2/+2
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1337034580-26987-2-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6589 Signed-off-by: David Sommerseth <davids@redhat.com>
* cleanup: spec: make space/tab consistentAlon Bar-Lev2012-06-011-17/+17
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1337034580-26987-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6590 Signed-off-by: David Sommerseth <davids@redhat.com>
* cleanup: update .gitignoreAlon Bar-Lev2012-06-011-0/+2
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1337120475-3959-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6596 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: check minimum polarssl versionAlon Bar-Lev2012-06-011-0/+21
| | | | | | | | | | | Pre 1.1 is unsupported, API was changed. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Reviewed-by: Adriaan de Jong <dejong@fox-it.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1337598254-32641-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6613 Signed-off-by: David Sommerseth <davids@redhat.com>
* repair t_client.sh test after build system revolutionGert Doering2012-06-012-8/+10
| | | | | | | | | | | | | | | - run t_client.sh at "make check" time - in t_client.sh, read t_client.rc from source *or* build dir (as before) - @IP@ evaluates to "" now (not "ip") if iproute2 not found - adapt script - introduce $SETUP_TIME_WAIT to delay "waiting for openvpn startup" longer than the default delay of 10 seconds - this is needed for test servers with a high network RTT Signed-off-by: Gert Doering <gert@greenie.muc.de> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 20120527202737.GV1161@greenie.muc.de URL: http://article.gmane.org/gmane.network.openvpn.devel/6616 Signed-off-by: David Sommerseth <davids@redhat.com>
* Some filesystems don't like ':', which is a path 'make dist' would useDavid Sommerseth2012-05-041-1/+1
| | | | | | | | | | In commit 7a845401043dbd9c the version.m4 was modified to remove the alpha1 tag. But then Alon Bar-Lev noticed that NTFS wasn't happy about the ':' character. So let's rather just skip the complete 'git:' prefix and use just 'master' instead. Reported-by: Alon Bar-Lev <alon.barlev@gmail.com> Signed-off-by: David Sommerseth <davids@redhat.com>
* Change version to indicate the master branch is not a versionDavid Sommerseth2012-05-031-1/+1
| | | | | | This also indicates that we're way past the released 2.3-alpha1 Signed-off-by: David Sommerseth <davids@redhat.com>
* Simplify check_cmd_access() functionDavid Sommerseth2012-05-031-22/+26
| | | | | | | | | | | | | | | | | | | To avoid confusion between check_file_access() and check_cmd_access() in the future, remove unneeded arguments from check_cmd_access() As a command will always be a file, it should always check for CHKACC_FILE and nothing else. And as the commands always will need X_OK, check only for that. One change from earlier behaviour is that R_OK is not checked for. The reason is that only scripts require R_OK to work. However, a system might be installed with binaries with only X_OK set. If a script is missing R_OK, then the execution will fail due to lacking permissions. Signed-off-by: David Sommerseth <davids@redhat.com> Acked-by: Alon Bar-Lev <alon.barlev@gmail.com> Message-Id: 1335981252-7390-1-git-send-email-davids@redhat.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6391
* build: windows: convert resources to UTF-8Alon Bar-Lev2012-05-032-2/+6
| | | | | | | | | | | Visual Studio 2010 editor supports UTF-8 files, we can store files in standard encoding. Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1335637741-15721-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6380 Signed-off-by: David Sommerseth <davids@redhat.com>
* Clarified the docs and help screen about what a 'cmd' isJonathan K. Bullard2012-05-022-61/+120
| | | | | | | | | | | | | | | | | | This also changes the descriptions of several options to note that they accept a "command"; change the description of --client-connect and --client-disconnect indicate that the temporary file's path is passed as the last argument to the command, not the first argument; and Adds a description of --route-pre-down to the descriptions of the other --route options. [DS: This patch is based on parts of the options.c.diff and the complete openvpn.8.diff patch sent to the mailing list - where these docs changes are merged together into this patch] Signed-off-by: Jonathan K. Bullard <jkbullard@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: CAEsd45RkyJw6yUk1Jwkip70HkCjKYoU+V=do3N7SH7JOaHBZdw@mail.gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6194 Signed-off-by: David Sommerseth <davids@redhat.com>
* Fix file access checks on commandsJonathan K. Bullard2012-05-021-21/+68
| | | | | | | | | | | | | | | | | | | | | The current implementation of check_file_access() does not consider that some options take scripts and executables as input. When some of these commands are given arguments in the OpenVPN configuration, check_file_access() would take those arguments as a part of the file name to the command. Thus the file check would fail. This patch improves that by introducing a check_cmd_access() function which first splits out the arguments to the command before checking if the file with the command is available. [DS: This patch is splitted out from the options.c.diff patch sent to the mailing list - where only the function changes is included here] Signed-off-by: Jonathan K. Bullard <jkbullard@gmail.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: CAEsd45RkyJw6yUk1Jwkip70HkCjKYoU+V=do3N7SH7JOaHBZdw@mail.gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6194 Signed-off-by: David Sommerseth <davids@redhat.com>
* Removed stray "Fox-IT hardening" string.Adriaan de Jong2012-04-281-1/+1
| | | | | | | | Signed-off-by: Adriaan de Jong <dejong@fox-it.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1333351687-3732-5-git-send-email-dejong@fox-it.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6212 Signed-off-by: David Sommerseth <davids@redhat.com>
* build: fix typo in --enable-save-passwordAlon Bar-Lev2012-04-281-0/+1
| | | | | | | | Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> Acked-by: David Sommerseth <davids@redhat.com> Message-Id: 1335534054-14895-1-git-send-email-alon.barlev@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6371 Signed-off-by: David Sommerseth <davids@redhat.com>
generated by cgit (git 2.34.1) at 2024-04-28 05:35:58 +0000