summaryrefslogtreecommitdiffstats
path: root/src/openvpn/misc.c
diff options
context:
space:
mode:
authorSteffan Karger <steffan@karger.me>2015-09-21 20:48:33 +0200
committerGert Doering <gert@greenie.muc.de>2015-10-04 21:55:29 +0200
commitddc7692d245017c71adc40ad5cc195617e39fce0 (patch)
tree2f5549f793513c854f289437d5446314719bf21f /src/openvpn/misc.c
parentc40f088e52132273f6d4e83d05fa64bbaedd860f (diff)
downloadopenvpn-ddc7692d245017c71adc40ad5cc195617e39fce0.tar.gz
openvpn-ddc7692d245017c71adc40ad5cc195617e39fce0.tar.xz
openvpn-ddc7692d245017c71adc40ad5cc195617e39fce0.zip
Replace strdup() calls for string_alloc() calls
As reported by Bill Parker in trac #600, strdup() return values are not always correctly checked for failed allocations. This patch adds missing checks by using string_alloc(), which performs the required checks. Signed-off-by: Steffan Karger <steffan@karger.me> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <561130FC.8090008@karger.me> URL: http://article.gmane.org/gmane.network.openvpn.devel/10176 Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src/openvpn/misc.c')
-rw-r--r--src/openvpn/misc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c
index 895e9fa..fd1930a 100644
--- a/src/openvpn/misc.c
+++ b/src/openvpn/misc.c
@@ -1615,7 +1615,7 @@ argv_extract_cmd_name (const char *path)
{
if (path)
{
- char *path_cp = strdup(path); /* POSIX basename() implementaions may modify its arguments */
+ char *path_cp = string_alloc(path, NULL); /* POSIX basename() implementaions may modify its arguments */
const char *bn = basename (path_cp);
if (bn)
{