diff options
| author | Gert Doering <gert@greenie.muc.de> | 2013-03-11 21:03:20 +0100 |
|---|---|---|
| committer | Gert Doering <gert@greenie.muc.de> | 2013-03-12 13:40:26 +0100 |
| commit | 0eb398501fab9c016b9b6008682c43873c4a6188 (patch) | |
| tree | bcc59e7e65cc30b42cf7cea2f64468e945aab091 /src/openvpn/mbuf.h | |
| parent | dc63e06b2c366f74752c8baa61b0f173d62511ad (diff) | |
| download | openvpn-0eb398501fab9c016b9b6008682c43873c4a6188.tar.gz openvpn-0eb398501fab9c016b9b6008682c43873c4a6188.tar.xz openvpn-0eb398501fab9c016b9b6008682c43873c4a6188.zip | |
Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout.
Return value of mbuf_len() wrong - it's returning a length value, not
a yes/no value - so when the queue length approached 65 (full!), it
still only returned "1", leading to MBUF overflow later on. Change
from "bool" to "unsigned int", misbehaviour gone...
This fixes OpenVPN trac ticket #263.
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Peter Caprioli <petercap@kth.se>
Message-Id: <20130312100706.GN953@greenie.muc.de>
URL: http://article.gmane.org/gmane.network.openvpn.devel/7396
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src/openvpn/mbuf.h')
| -rw-r--r-- | src/openvpn/mbuf.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/mbuf.h b/src/openvpn/mbuf.h index a0de679..1085adc 100644 --- a/src/openvpn/mbuf.h +++ b/src/openvpn/mbuf.h @@ -83,7 +83,7 @@ mbuf_defined (const struct mbuf_set *ms) return ms && ms->len; } -static inline bool +static inline unsigned int mbuf_len (const struct mbuf_set *ms) { return ms->len; |