summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdriaan de Jong <dejong@fox-it.com>2012-02-04 14:16:13 +0100
committerDavid Sommerseth <davids@redhat.com>2012-02-04 15:56:45 +0100
commit5b5420573cd6c78e1a87eaa4946e13b9150f9076 (patch)
treee1ebd7e21491c5847d573b4958c9807d1c409349
parent1951b415ed37187c26997f3fe1eb4c59e8dbf298 (diff)
downloadopenvpn-5b5420573cd6c78e1a87eaa4946e13b9150f9076.tar.gz
openvpn-5b5420573cd6c78e1a87eaa4946e13b9150f9076.tar.xz
openvpn-5b5420573cd6c78e1a87eaa4946e13b9150f9076.zip
Minor code cleanup: cleaned up error handling in verify_cert.
Removed done label and cleaned up return values. Signed-off-by: Adriaan de Jong <dejong@fox-it.com> Acked-by: David Sommerseth <davids@redhat.com> Signed-off-by: David Sommerseth <davids@redhat.com>
-rw-r--r--ssl_verify.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/ssl_verify.c b/ssl_verify.c
index 0b2a1fb..e45f149 100644
--- a/ssl_verify.c
+++ b/ssl_verify.c
@@ -669,14 +669,14 @@ verify_cert(struct tls_session *session, x509_cert_t *cert, int cert_depth)
msg (D_HANDSHAKE, "VERIFY OK: depth=%d, %s", cert_depth, subject);
session->verified = true;
- done:
x509_free_subject (subject);
- return (session->verified == true) ? SUCCESS : FAILURE;
+ return SUCCESS;
err:
tls_clear_error();
session->verified = false;
- goto done;
+ x509_free_subject (subject);
+ return FAILURE;
}
/* ***************************************************************************