summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitri Pal <dpal@redhat.com>2010-12-24 21:25:56 -0500
committerStephen Gallagher <sgallagh@redhat.com>2011-01-03 14:13:42 -0500
commitb823a0743afc9d09ee93ff39b597e759e66fd1ed (patch)
tree833d902c2816c04dfcc9ba01ff7c3cdf22aa67f4
parent859df7ddd1bf1f36ce05966482086ecfb6c81e11 (diff)
downloadding-libs-b823a0743afc9d09ee93ff39b597e759e66fd1ed.tar.gz
ding-libs-b823a0743afc9d09ee93ff39b597e759e66fd1ed.tar.xz
ding-libs-b823a0743afc9d09ee93ff39b597e759e66fd1ed.zip
Freeing memory used for source dir
I decided not to redo the whole test. It would have been too much work. Just cleaned the code a bit and freed allocated memory. It is Coverity issue 10075.
-rw-r--r--ini/ini_config_ut.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/ini/ini_config_ut.c b/ini/ini_config_ut.c
index cbd4d4f..53ad334 100644
--- a/ini/ini_config_ut.c
+++ b/ini/ini_config_ut.c
@@ -1546,6 +1546,7 @@ int main(int argc, char *argv[])
int error = EOK;
char *srcdir = NULL;
char *rundir = NULL;
+ const char inidir[] = "/ini";
if ((argc > 1) && (strcmp(argv[1], "-v") == 0)) verbose = 1;
@@ -1553,13 +1554,15 @@ int main(int argc, char *argv[])
srcdir = getenv("srcdir");
if(srcdir) {
- rundir = malloc(strlen(srcdir)+4*sizeof(char));
- sprintf(rundir, "%s/ini", srcdir);
+ rundir = malloc(strlen(srcdir) + sizeof(inidir));
+ sprintf(rundir, "%s%s", srcdir, inidir);
if(chdir(rundir) != 0) {
error = errno;
+ free(rundir);
printf("Failed to change directory, error %d\n", error);
return error;
}
+ free(rundir);
}
if ((error = basic_test()) ||