Factor out add-disk code

The variety of approaches to 'add_disk' are factored out into
a separate function, and Incremental mode benefits by being
closer to supporting the assembly of containers.

Also remove the adding-to-array-data-structure out of sysfs_add_disk
and into add_disk.

And add some tests for --incremental mode to make sure we don't break it.

Signed-off-by: NeilBrown <neilb@suse.de>

1 files changed, 0 insertions, 7 deletions

diff --git a/sysfs.c b/sysfs.c
index 9ef5b39..fdad790 100644
--- a/sysfs.c
+++ b/sysfs.c
@@ -456,7 +456,6 @@ int sysfs_add_disk(struct mdinfo *sra, struct mdinfo *sd)
 {
 	char dv[100];
 	char nm[100];
-	struct mdinfo *sd2;
 	char *dname;
 	int rv;
 
@@ -482,12 +481,6 @@ int sysfs_add_disk(struct mdinfo *sra, struct mdinfo *sd)
 		rv |= sysfs_set_num(sra, sd, "slot", sd->disk.raid_disk);
 //		rv |= sysfs_set_str(sra, sd, "state", "in_sync");
 	}
-	if (! rv) {
-		sd2 = malloc(sizeof(*sd2));
-		*sd2 = *sd;
-		sd2->next = sra->devs;
-		sra->devs = sd2;
-	}
 	return rv;
 }