summaryrefslogtreecommitdiffstats
path: root/super1.c
diff options
context:
space:
mode:
authorNeil Brown <neilb@suse.de>2008-07-12 20:27:36 +1000
committerNeil Brown <neilb@suse.de>2008-07-12 20:27:36 +1000
commita0c8a17f66f944151434dff06dd28c83e0893e88 (patch)
tree7fceeb47ba54465b3c6beebe69c26efb4723e076 /super1.c
parent6264b43733127177d3fab4492a2da75938e7e881 (diff)
downloadmdadm-a0c8a17f66f944151434dff06dd28c83e0893e88.tar.gz
mdadm-a0c8a17f66f944151434dff06dd28c83e0893e88.tar.xz
mdadm-a0c8a17f66f944151434dff06dd28c83e0893e88.zip
Fix write_init_super usage when hot-adding a spare
Using write_init_super to add a spare to an active array is quite different to how it is used when creating an array. It mostly works, but if we are adding two devices to an array, then when we add the second, there are still traces of the first which confuse write_init_super. So get write_init_super to ignore those traces. Longer term, we probably want to do this differently as for DDF, hot-adding to an active array will have to be quite different - it will want to write to all metadata, possibly via mdmon.
Diffstat (limited to 'super1.c')
-rw-r--r--super1.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/super1.c b/super1.c
index 0fe54e9..bebd5f9 100644
--- a/super1.c
+++ b/super1.c
@@ -900,16 +900,12 @@ static int write_init_super1(struct supertype *st)
for (di = st->info; di && ! rv ; di = di->next) {
if (di->disk.state == 1)
continue;
+ if (di->fd < 0)
+ continue;
Kill(di->devname, 0, 1, 1);
Kill(di->devname, 0, 1, 1);
- if (di->fd < 0) {
- fprintf(stderr,
- Name": Failed to open %s to write superblock\n",
- di->devname);
- return -1;
- }
sb->dev_number = __cpu_to_le32(di->disk.number);
if (di->disk.state & (1<<MD_DISK_WRITEMOSTLY))
sb->devflags |= __cpu_to_le32(WriteMostly1);