summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2010-07-01 17:28:14 -0700
committerDan Williams <dan.j.williams@intel.com>2010-07-01 17:28:14 -0700
commit23eb475a96b1b0cf7f8feaeb7b32355b80e8faa7 (patch)
tree90ed0d780d61e3b7d1112b96b7349e222ec95e48
parentb526e52dc7cbdde98db9c9f8765be28ba6d71d78 (diff)
downloadmdadm-23eb475a96b1b0cf7f8feaeb7b32355b80e8faa7.zip
mdadm-23eb475a96b1b0cf7f8feaeb7b32355b80e8faa7.tar.gz
mdadm-23eb475a96b1b0cf7f8feaeb7b32355b80e8faa7.tar.xz
mdmon: prevent allocations due to late binding
Current versions of glibc do not provide a useable interface to clone(2) as it inflicts hidden dependencies on setting up a glibc specific tls descriptor. The dynamic linker trips this dependency and causes mdmon to intermittently fail to load. Resolving all dynamic linking prior to starting the monitor thread appears to mitigate the issue but there is no guarantee that another tls dependency will bite us later. However, while the debate continues with the glibc maintainers it seems prudent to keep this change. It ensures that we do not get into a situation where the monitor thread needs to make a late allocation to resolve a symbol. Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r--Makefile3
1 files changed, 2 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 3af1665..237f4fc 100644
--- a/Makefile
+++ b/Makefile
@@ -157,8 +157,9 @@ mdadm.O2 : $(SRCS) mdadm.h mdmon.O2
mdmon.O2 : $(MON_SRCS) mdadm.h mdmon.h
$(CC) -o mdmon.O2 $(CFLAGS) -DHAVE_STDINT_H -O2 -D_FORTIFY_SOURCE=2 $(MON_SRCS)
+# use '-z now' to guarantee no dynamic linker interactions with the monitor thread
mdmon : $(MON_OBJS)
- $(CC) $(LDFLAGS) -o mdmon $(MON_OBJS) $(LDLIBS)
+ $(CC) $(LDFLAGS) -z now -o mdmon $(MON_OBJS) $(LDLIBS)
msg.o: msg.c msg.h
test_stripe : restripe.c mdadm.h